Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
minleejae
marked this pull request as ready for review
September 28, 2026 08:38
Signed-off-by: minleejae <mmj9808@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER TABLE t REPLICA IDENTITY NOTHINGfails with the PostgreSQL dialect after the typed relation-action dispatch introduced in #2707. PostgreSQL 18.6 accepts the statement, and JSqlParser 5.4 preserved it through its generic ALTER path.Accept the existing
K_NOTHINGtoken in the replica-identity production and retain the existingRelationAlterAction.ReplicaIdentityAPI. Regression tests cover DEFAULT/FULL/NOTHING, structured AST inspection, changing the mode to NOTHING, both rendering paths, reparsing, and statement-list parsing.Validation: the new tests fail on the baseline (4 failures), then all 74
PostgreSqlRelationAlterTestcases pass after regenerating the parser. JJTree/JavaCC generation reports no unexpected warnings or choice conflicts, and all production sources compile with Java 17 targeting Java 11. Full Gradle/Maven checks remain for CI.The original SQL was executed successfully on PostgreSQL 18.6 during the corpus investigation. Re-executing the patched parser's output against PostgreSQL was blocked by local connection permissions and is not claimed here.