Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL accepts
CREATE RULE r AS ON INSERT TO t DO ALSO NOTIFY ddl_probe, but JSqlParser could not parse the rule or its NOTIFY action.Add a structured CREATE RULE node that reuses existing SELECT/INSERT/UPDATE/DELETE/TABLE statement ASTs for actions, plus a NOTIFY node usable both independently and inside a rule. Preserve event, condition, ALSO/INSTEAD behavior, NOTHING, and grouped action lists. Route nested actions through normal visitors/deparsers so SQL expressions and table references remain accessible. NOTIFY stays usable as an unquoted identifier.
Tests cover nested actions and mutations, custom expression deparsing, semicolon and following-statement boundaries, parenthesized set operations, and invalid actions/payloads. Executed 16 rule scenarios and two standalone NOTIFY scenarios on PostgreSQL 18.6, comparing rule catalog definitions and, where applicable, effects on table contents after original and rendered SQL.
Syntax references: CREATE RULE, NOTIFY. Event/NEW/OLD restrictions that require database catalog analysis remain the server's responsibility.
Validation: focused tests, JavaCC ambiguity checks, Checkstyle and Spotless on this independent branch. The combined implementation also passes the full Gradle check and Maven verify; the 1,304-input prior regression corpus has no previously successful input regressions.