Reuse foreign-data options for PostgreSQL wrappers, servers and user mappings - #2720
Merged
manticore-projects merged 1 commit intoSep 27, 2026
Conversation
… user mappings Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL foreign tables already use structured ForeignDataOption nodes, but CREATE/ALTER FOREIGN DATA WRAPPER, SERVER and USER MAPPING were still unsupported. This prevents parsing complete foreign-data setup scripts.
Reuse the foreign-table option parser/model across these objects, including ALTER ADD/SET/DROP operations. Model handler/validator declarations, server TYPE/VERSION (including explicit NULL), mapping users, and supported rename/owner actions. Wire statement visitors, expression deparsing and feature validation. Guard contextual-keyword lookahead against EOF so a final function name such as handler cannot be mistaken for another clause.
Tests cover option mutations, handler/validator order, absent versus explicit NO/NULL forms, invalid CREATE options, statement boundaries, and existing CREATE USER/foreign-table paths. Executed accepted audit cases and 20 additional scenarios on PostgreSQL 18.6; wrapper, server and user-mapping catalog state matches for original SQL and both renderers.
Syntax references: CREATE FOREIGN DATA WRAPPER, CREATE SERVER, CREATE USER MAPPING.
Validation: focused tests, JavaCC ambiguity checks, Checkstyle and Spotless on this independent branch. The combined implementation also passes the full Gradle check and Maven verify; the 1,304-input prior regression corpus has no previously successful input regressions.