Structure PostgreSQL column type and generated expression replacements - #2716
Merged
manticore-projects merged 1 commit intoSep 27, 2026
Conversation
…ements Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL accepts
ALTER TABLE t ALTER COLUMN id SET DATA TYPE bigint USING id::bigint, but the parser rejected SET DATA TYPE.ALTER COLUMN g SET EXPRESSION AS (...)could parse as a column type change, leaving the expression inaccessible through the appropriate AST node.Share the TYPE/SET DATA TYPE prefix between ALTER TABLE and ALTER TYPE, and share generated-expression parsing/rendering with CREATE TABLE. Add a distinct SET_EXPRESSION action whose expression participates in visitors and deparsing, while retaining existing type-change accessors.
Tests cover both type prefixes, USING/COLLATE, composite attributes, optional COLUMN, expression mutation and custom deparsing, multiple actions, and invalid contexts. Relevant corpus cases were executed on PostgreSQL 18.6 using original SQL, toString output, and StatementDeParser output; resulting catalog definitions match.
Syntax references: ALTER TABLE, ALTER TYPE.
Validation: focused tests, JavaCC ambiguity checks, Checkstyle and Spotless on this independent branch. The combined implementation also passes the full Gradle check and Maven verify; the 1,304-input prior regression corpus has no previously successful input regressions.