fix: share PostgreSQL column key and storage parameter parsing - #2709
Merged
manticore-projects merged 1 commit intoSep 25, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL column PRIMARY KEY / UNIQUE storage and tablespace options were left outside the constraint AST. Updating Index.setStorageParameters or setTableSpace therefore printed both the replacement and the original clause. Bare storage options such as WITH (autovacuum_enabled) also failed in several CREATE contexts.
Share the storage/tablespace parser between column and table constraints, keeping column-level INCLUDE disallowed. Let the shared storage-option parser preserve omitted values, while requiring values and equals signs in PostgreSQL operator-class parameter contexts. Existing Index.Option nodes provide the mutable representation and both output paths.
Validation: full Gradle check and grammar ambiguity gate; 31 valid PostgreSQL 18.6 cases preserve selected catalog results across original, toString and deparser SQL. Four column-option mutation regressions and a table-constraint control execute correctly. Eight column-INCLUDE variants are rejected by PostgreSQL and excluded from the valid-case count.