Repository navigation
Grid script: keep a cached old script from breaking the number slider - #11
Merged
Merged
Conversation
…ak the slider On a phone that still had the v7 app/script.js and lib/glyph.js cached, the new page's COUNT.4.171 example threw in the old parser, which stopped the explainer before the number slider was wired up. The pages now load app/script.js?v=8 (and it loads lib/glyph.js and the vocab with the same version), and each example is drawn on its own so one failure can't take down the rest of the page. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QgskKyin9t8k9F6KcUj5o7
❌ Deploy Preview for interimm-interstellar failed.
|
Member
Author
|
The repo's own Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: on a phone that still had the previous (v7)
app/script.jsandlib/glyph.jsin its cache, the new /script/ page did nothing when you moved the number slider, and its drawing and bits stayed empty. The new page includes aCOUNT.4.171example. The old cached parser rejects it, and that error stopped the explainer before the slider was wired up.After: the slider and every example work, even right after a deploy.
How:
app/script.js?v=8.lib/glyph.jsand the vocabulary with the same version tag, so a new page never runs against old cached code. Bump the?v=whenever the script changes.Checks:
npm testpasses (22 tests). In Chromium emulating a Pixel 7, all six pages load with no console errors, and tapping the slider updates the drawing.🤖 Generated with Claude Code
https://claude.ai/code/session_01QgskKyin9t8k9F6KcUj5o7
Generated by Claude Code