Repository navigation
task: agent ready prep - #190
jharlow-intel wants to merge 4 commits into
Conversation
f1ad7e4 to
6113eb5
Compare
| (`brng_list`) | ||
| - `mkl_distributions.cpp`, `mkl_distributions.h` — distribution kernels on MKL | ||
| VS | ||
| - `mklrand_py_helper.h` — Python/NumPy helpers for the extension |
There was a problem hiding this comment.
lists a file that no longer exists
| pytest mkl_random/tests | ||
| pre-commit run --all-files |
There was a problem hiding this comment.
The Checks section can't be run from the Setup section's environment.
The above conda create doesn't install pre-commit or pylint.
There was a problem hiding this comment.
Added pre-commit and pylint to the conda create in e1d971b. pylint is needed because it runs as a language: system hook.
| `interfaces.numpy_random.RandomState` for the NumPy drop-in in new code and | ||
| docs; `mkl_random.RandomState` is deprecated. | ||
| - Edit `mklrand.pyx`; Cython generates the C++ into the build directory. | ||
| - Adding a basic generator touches every registration point: the enum in |
There was a problem hiding this comment.
The new-generator checklist leaves out BRNG_KINDS.
That constant is set to 11, and the array brng_list[BRNG_KINDS] is sized by it. Forgetting it breaks the build with a "too many initializers" error rather than failing silently, as the automated review claimed. The checklist is meant to be complete, though, so it should name it
There was a problem hiding this comment.
Added in e1d971b: the checklist now names BRNG_KINDS in src/randomkit.h as the count that sizes brng_list.
| The editable (``-e``) install builds the extension in place, so the test suite | ||
| below runs against it from the repository root. |
There was a problem hiding this comment.
That wrongly says the editable install "builds the extension in place". meson-python builds into build/cp3XX/ and installs an import hook that rebuilds on import. No compiled extension file ever appears in mkl_random/.
Switching the command to -e is correct: with a normal install, pytest mkl_random/tests from the repo root imports the source tree, which has no compiled extension.
Only the explanation needs rewording, for example:
makes the source tree importable and rebuilds the extension on import
There was a problem hiding this comment.
Reworded with your phrasing in e1d971b.
|
|
||
| ## Setup | ||
|
|
||
| Building needs a C++ compiler (`g++`, `clang++`, or `icpx`). |
There was a problem hiding this comment.
Added in e1d971b (the conda recipes use compiler('cxx'), which is MSVC on Windows). The docs Contributing page had the same gap, so it now lists MSVC too.
Drop mklrand_py_helper.h from src/AGENTS.md (removed in gh-192), name BRNG_KINDS in the new-generator checklist, list MSVC as the Windows compiler, add pre-commit and pylint to the dev environment so the Checks section runs from it, and describe the meson-python editable install accurately.
Very similar to IntelPython/mkl_fft#379: adds contributor and coding-agent guidance (
CONTRIBUTING.md,AGENTS.md), PR and issue templates,SECURITY.md, and a README pointer, checked against this repo's build and CI. It also fixes the build and test commands on the docs Contributing page.