Repository navigation
Read sysroot glibc version without conda CLI in build.sh - #3126
Merged
Merged
Conversation
The `ubuntu-latest` GitHub runner moved to ubuntu-26.04, which no longer ships Miniconda. The rattler-build job relied on it to run `conda list`, so the glibc version came out empty and the wheel was retagged as `manylinux___x86_64`, which pip then rejected. Read the `sysroot_linux-64` version from the build env `conda-meta` records instead, which both rattler-build and conda-build provide, and fail early if it cannot be detected.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 25, 2026 13:23
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev16=np2py314h8d9cdd5_4 ran successfully. |
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3126/index.html |
Collaborator
|
coverage: 82.64%. remained the same — fix-glibc-tag-without-conda into master |
vlad-perevezentsev
approved these changes
Oct 26, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux jobs of the
Conda packageworkflow started failing at the wheel install step (e.g. this run) with:The
ubuntu-latestrunner image switched fromubuntu-24.04toubuntu-26.04. The new image does not ship Miniconda, socondais no longer onPATH.conda-recipe/build.shusedconda list '^sysroot_linux-64$'to get the glibc version for themanylinuxplatform tag. Under rattler-build that call now fails withconda: command not found, both version parts end up empty, andwheel tagsproduces the invalidmanylinux___x86_64tag.This PR reads the
sysroot_linux-64version from theconda-metarecord in${BUILD_PREFIX}instead. The package is a build requirement (stdlib('c')) in bothrattler_recipe.yamlandmeta.yaml, so the record is there under both rattler-build and conda-build. The script now also fails early with a clear error if the version cannot be detected, instead of silently producing a broken tag. It also skips theconda listcall, which took ~30 seconds per build.