Repository navigation
Add a shared CMake helper for the backend extensions - #3111
Merged
Merged
Conversation
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 15, 2026 18:34
antonwolfy
added a commit
that referenced
this pull request
Oct 15, 2026
New extensions call build_dpnp_pybind11_ext instead of copying an existing CMakeLists.txt, and request -fno-sycl-id-queries-fit-in-int with its LARGE_RANGES option.
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev16=np2py314h8d9cdd5_9 ran successfully. |
Collaborator
antonwolfy
force-pushed
the
cmake-extension-helper
branch
from
October 22, 2026 19:26
4edef44 to
7e724b0
Compare
All build requirements (pyproject.toml and the conda recipes) already need CMake 3.31.6 or newer, and FetchContent with FIND_PACKAGE_ARGS needs 3.24, so the minimum of 3.21 was not accurate. Raising it to 3.27 removes the need for the Windows workaround for target_link_options in older CMake versions. The policy level stays at 3.27, as before.
The nine extensions in dpnp/backend/extensions repeated the same target setup. Move it into build_dpnp_pybind11_ext in dpnp/CMakeLists.txt; each extension now lists its sources and extra include directories, keeps its own oneMKL/oneMath linking, and passes LARGE_RANGES when its kernels can be launched over more than INT_MAX work-items. The vm extension now also gets the -fsycl-targets options when building for custom SYCL targets, like the other extensions.
antonwolfy
force-pushed
the
cmake-extension-helper
branch
from
October 23, 2026 11:13
7e724b0 to
ad09ed0
Compare
vlad-perevezentsev
self-requested a review
October 26, 2026 10:36
vlad-perevezentsev
approved these changes
Oct 26, 2026
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Oct 26, 2026
This PR moves the setup that the nine pybind11 extensions in `dpnp/backend/extensions` repeat into one CMake function, and raises the minimum CMake version so the workarounds for older versions can be removed. It is stacked on #3104 and will be rebased onto master once that PR is merged. 1. **Require CMake 3.27.** `cmake_minimum_required(VERSION 3.21...3.27)` claimed that CMake 3.21 was enough, but `pyproject.toml` and the conda recipes already require CMake 3.31.6 or newer, and `FetchContent_Declare(... FIND_PACKAGE_ARGS)` for pybind11 needs at least 3.24. The minimum is now 3.27, which removes the 11 copies of the Windows workaround for `target_link_options` in CMake older than 3.27. The policy level stays at 3.27, as builds use today, so no CMake policy changes behavior. 2. **Shared helper.** The nine extension `CMakeLists.txt` files repeated about 80 identical lines: the pybind11 module, SYCL, the `_usmarray` dependency, fat-binary options, include directories, math flags, device code split, coverage, the redistribution rpath and install. `build_dpnp_pybind11_ext` in `dpnp/CMakeLists.txt` now does this. Each extension lists its sources and extra include directories, keeps its own oneMKL/oneMath linking, and passes `LARGE_RANGES` when its kernels can be launched over more than `INT_MAX` work-items (`indexing`, `statistics`, `ufunc`, `window`), which adds `-fno-sycl-id-queries-fit-in-int` at compile and link time. A new extension can no longer miss one of these options by copying an outdated file. The only change in the generated build is for the `vm` extension: it had no fat-binary block, so it was the one extension built without `-fsycl-targets` when `DPNP_TARGET_CUDA`, `DPNP_TARGET_HIP` or `DPNP_SYCL_TARGETS` is set. It now gets these options like the others. `vm` compiles no kernels of its own, and in CUDA/HIP builds it compiles only `vm_py.cpp` and the two shared elementwise helper sources that `ufunc` already compiles with these options. **Verification.** The project was configured with CMake 4.4.4, Ninja and icpx 2026.1, with and without this change on top of the same base, and every compile and link command (`ninja -t commands` and `compile_commands.json`), the generated install rules and the configure warnings were compared: | Configuration | Result | |---|---| | Release (oneMKL) | identical | | Coverage with `DPNP_GENERATE_COVERAGE`, `DPNP_WITH_REDIST` and `DPNP_SYCL_TARGETS=spir64-unknown-unknown` | identical, except `-fsycl-targets` on the `vm` compile and link commands | | Release with `DPNP_USE_ONEMATH=ON` | identical | Windows builds are covered by CI. 2fe6540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the setup that the nine pybind11 extensions in
dpnp/backend/extensionsrepeat into one CMake function, and raises the minimum CMake version so the workarounds for older versions can be removed. It is stacked on #3104 and will be rebased onto master once that PR is merged.cmake_minimum_required(VERSION 3.21...3.27)claimed that CMake 3.21 was enough, butpyproject.tomland the conda recipes already require CMake 3.31.6 or newer, andFetchContent_Declare(... FIND_PACKAGE_ARGS)for pybind11 needs at least 3.24. The minimum is now 3.27, which removes the 11 copies of the Windows workaround fortarget_link_optionsin CMake older than 3.27. The policy level stays at 3.27, as builds use today, so no CMake policy changes behavior.CMakeLists.txtfiles repeated about 80 identical lines: the pybind11 module, SYCL, the_usmarraydependency, fat-binary options, include directories, math flags, device code split, coverage, the redistribution rpath and install.build_dpnp_pybind11_extindpnp/CMakeLists.txtnow does this. Each extension lists its sources and extra include directories, keeps its own oneMKL/oneMath linking, and passesLARGE_RANGESwhen its kernels can be launched over more thanINT_MAXwork-items (indexing,statistics,ufunc,window), which adds-fno-sycl-id-queries-fit-in-intat compile and link time. A new extension can no longer miss one of these options by copying an outdated file.The only change in the generated build is for the
vmextension: it had no fat-binary block, so it was the one extension built without-fsycl-targetswhenDPNP_TARGET_CUDA,DPNP_TARGET_HIPorDPNP_SYCL_TARGETSis set. It now gets these options like the others.vmcompiles no kernels of its own, and in CUDA/HIP builds it compiles onlyvm_py.cppand the two shared elementwise helper sources thatufuncalready compiles with these options.Verification. The project was configured with CMake 4.4.4, Ninja and icpx 2026.1, with and without this change on top of the same base, and every compile and link command (
ninja -t commandsandcompile_commands.json), the generated install rules and the configure warnings were compared:DPNP_GENERATE_COVERAGE,DPNP_WITH_REDISTandDPNP_SYCL_TARGETS=spir64-unknown-unknown-fsycl-targetson thevmcompile and link commandsDPNP_USE_ONEMATH=ONWindows builds are covered by CI.