Repository navigation
fix: allowlist a gitleaks false positive on a test idempotency key - #115
Merged
Merged
Conversation
generic-api-key flagged the literal fixture string "idem-orphan-deal-1" in test_unresolvable_deal_id_does_not_create_pending_cr (PR #71) for sitting next to a key named idempotency_key. Low entropy (3.57), not a credential. Allowlisted per CONTRIBUTING.md's documented gitleaks:allow convention, same as the existing one at line 650.
Kishore-2572
marked this pull request as ready for review
October 9, 2026 12:09
Sirajmx
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defect
The post-merge
hygieneworkflow onmainfailed after #71 landed: https://github.com/IABTechLab/seller-agent/actions/runs/37925700129gitleaks'sgeneric-api-keyrule flagged a new test fixture string added by #71 —"idempotency_key": "idem-orphan-deal-1"attests/unit/test_change_request.py:308— for being a quoted string next to a key namedidempotency_key.Verified this is a false positive, not a real secret
test_unresolvable_deal_id_does_not_create_pending_cr, not a credential of any kind.gitleakslocally: confirmed it flags the line without an allow comment, and clears clean with one.The fix
One line: added
# gitleaks:allowperCONTRIBUTING.md's documented convention for confirmed false positives — no config file needed in this repo.Verification
ruff check/ruff format --check: clean.gitleaksre-run locally on the file: no leaks found.Test plan
uv run pytest tests/unit -quv run ruff check/ruff format --checkgitleaksre-run locally, confirmed clean