Repository navigation
Emit Content Taxonomy 3.1 IDs with cattax 9, and ship the full catalog in the JS package - #1
Open
esteininger wants to merge 1 commit into
Open
esteininger wants to merge 1 commit into
esteininger wants to merge 1 commit into
Conversation
…g in the JS package - Default cattax 2 -> 9 (AdCOM: 2 is Content Taxonomy 2.0, 9 is 3.1). - JS package ships the 3.1 (704) and 2.2 catalogs the Python package has. - synonyms_3x.json keyed by label, as both mappers look it up. - A 2.x code with no label maps through the 2.x catalog. - Version 1.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in what the mapper emits, and prepares 1.1.0.
cattaxchanges from2to9. In AdCOM's List: Category Taxonomies, 2 is Content Taxonomy 2.0 and 9 is 3.1, and the bundled catalog is 3.1. With the old default, every output told receivers to read 3.x IDs as 2.0 codes. Every 3.0 ID is also a 3.1 ID, so callers that need 3.0 can passcattax: 7and get the same output.javascript/data/iab_3x.jsonheld a 6-row sample whose IDs (for example3-5-2for Cooking, which is216in the official file) do not exist in Content Taxonomy 3.1.synonyms_3x.jsonis keyed by label, which is how both mappers look synonyms up. The path-keyed entries never matched, and "Team Sports" is not a 3.1 label.codeand nolabelnow maps, by looking the label up in the bundled 2.x catalog. Before,{"code": "1"}returned no IDs.Tests: Python 9 passed, with the same 5 failures as
main(checked on 13cddec). JavaScript 49 of 50, with the same unicode-normalization failure asmain.Most of the
cli.pydiff is formatting (black and isort), because the copy this came from is formatted that way; its behavior change is the one-linecattaxdefault.