Repository navigation
§ 4.1, § 7 — Proposal templates and issued proposals (#26) - #74
Draft
Kishore-2572 wants to merge 1 commit into
Draft
Kishore-2572 wants to merge 1 commit into
Kishore-2572 wants to merge 1 commit into
Conversation
§ 4.1 adds an optional, immutable proposal_template_id linking an issued proposal to the seller's template. Each issued proposal has its own status, version and negotiation_history[], and buyers never need the template id to transact. § 7 adds a non-normative note separating seller-side templates from the issued proposals buyers commit against. Appendix A gains one row; Appendix B counts immutable 6 → 7 and 72 fields. The proposal example carries a proposal_template_id. Refs #26
10 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A proposal can now carry an optional, immutable
proposal_template_id(§ 4.1) linking an issued proposal to the seller's template, so issued copies of one template can be told apart and traced back to it. Each issued proposal has its ownstatus,versionandnegotiation_history[], and buyers never need the template id to transact. § 7 adds a non-normative note separating seller-side templates from the issued proposals buyers see and commit against.Related issue
Refs #26. Related: #27 (buyer-specific terms live on issued proposals).
Type
Checklist
scripts/check_appendix.pypassesimmutable6 → 7; 71 → 72 fieldsexamples/is updated and still parses —proposal_template_idinproposal.yamlselectabledeclaresavailable[]andincluded[]; anythingsettabledeclares bounds (§ 3.1, § 3.2) — no newselectableorsettablefieldsKnock-on effects
visibility,eligible_bidders[]andpricing[]are line-item fields (§ 5.6, § 5.8). "Proposal Store" is described as the seller's own systems, as the specification does not define it.issued_from: { proposal_id, version }naming the shared proposal an issued proposal was created from. It points to a public proposal, whereproposal_template_idpoints to a seller-internal template, so the two could coexist;requested_rate), state howagreed_rateis derived, and say who can readfloorandseller_rate#30 (counters on issued proposals) and [Comment] § 2 — The draft does not say what a parser does with a key it does not define #33 (handling of keys buyers do not resolve).examples/proposal.yamlis also changed by § 2, § 4.1, § 5.6 — Line-item dependencies and bonus lines (#23) #70 (linked_execution: none); whichever merges later rebases.By opening this pull request I agree my contribution may be published under this
repository's licence, as set out in CONTRIBUTING.md.