Repository navigation
Conversation
A line item whose rate differs by market can declare geo with the selectable structure of § 3.1: available[], included[], pricing deltas and max_select. A geo that declares only allowed[] stays settable, so existing payloads are unchanged. When several priced markets are selected, the highest delta applies. The audio example is priced by market. Refs #14
Open
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A line item can now be priced by market.
geomay declare the selectable structure of § 3.1 —available[]markets, the onesincluded[]in the base rate, per-marketpricingdeltas andmax_select— so a buyer composing a geo-scoped buy gets the geo-scoped rate without a round trip. Ageothat declares onlyallowed[]issettable, exactly as today. This is part 1 of #14; part 2 (pricing[].guidance) is #19.Related issue
Refs #14
Type
Checklist
geomarkersettable→selectable;scripts/check_appendix.pypassesselectable12 → 13,settable5 → 4; totals unchangedexamples/is updated and still parses — the audio example is priced by marketselectabledeclaresavailable[]andincluded[]; anythingsettabledeclares bounds (§ 3.1, § 3.2)Knock-on effects
geobecomesselectable, with a fallback: ageocarrying onlyallowed[]issettable. § 3.1 already has the same kind of fallback for aselectablefield with a bare value. Existingallowed[]payloads don't change, so this isn't breaking.geowith price deltas, andpricing[].guidancepercentiles alongsidefloor#14 nor its discussion says, so this PR doesn't decide it. Options include the highest delta, a blended rate, or one rate per market (which would also change the § 5.6.1 commitment).geowith price deltas, andpricing[].guidancepercentiles alongsidefloor#14 as filed. The open question above is left to the working group, not added to the spec text.floorstays line-level. A per-market floor would be a further change.By opening this pull request I agree my contribution may be published under this
repository's licence, as set out in CONTRIBUTING.md.