Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#94 treats
pricing[]as alternatives, while #115 adds seller fees as extrarows and leaves
derived_unitsunchanged. At USD 25 CPM, a USD 50,000 commitmentcontaining a USD 2,500 fee leaves USD 47,500 for media, or 1.9 million impressions.
Using the whole commitment as media instead implies USD 52,500 including the fee.
This adds focused wording for that fee basis and an executable discussion
profile. The 49 fixed vectors cover price selection, fee-inclusive spend,
unit commitments and budget bounds. The supporting calculator also exercises
the final-rate reading from #30 without reapplying option rate adjustments.
Floor composition and automatic acceptance remain separate decisions in #30.
The adapter preserves an explicitly accepted counter below a posted floor and
returns
floor_check: not_checked. A successful calculation does not establishseller acceptance, reserve inventory or authorize a commitment. Tax-inclusive
amounts, print adjustments and general mandatory-fee structures are outside
this limited profile.
The normative spec and field indexes are unchanged. If the fee wording is
adopted, the affected body, appendix and example updates should land together.
Validation: 49 vectors, existing appendix checks and YAML parsing pass. Four
deliberate arithmetic regressions fail the relevant vectors, including a
reintroduced floor veto on an already accepted counter.
Refs #94 and #115. Related: #30.
Member of the IAB Tech Lab Agentic Taskforce, commenting in a personal capacity.