Repository navigation
Show growing degree days on a planting, and tidy the planting fact cards - #5524
Merged
Merged
Conversation
- Implement `heat_so_far` and `heat_needed` methods in the PredictHarvest module to calculate the heat accumulated and required for crops. - Enhance the GrowingDegreeDays service with a `total` method to sum heat readings. - Add corresponding tests for the new methods in planting and growing degree days specs.
Reads "412 of about 850 needed", or "412 so far" when the crop's need isn't known. A question-mark popover says they are not calendar days.
Fills clockwise with the percentage in the middle, in the same colours as the progress bar. It stops at full for a planting that has run late.
Says to write the code on your plant label to find that exact plant later. The question-mark button is now a shared partial, which the growing degree days card uses too.
The icon is larger, with amber for full sun. It uses a solid sun, and a tree for shade, and the words under it say "full sun" or "partial shade".
A planting with no temperature readings for its days showed "0 of about N needed", which read as a cold season. It now shows no card.
…havior to open on click
- Update planting and crop chip components to display variety in brackets. - Enhance planting serializer to include variety information. - Modify views to show variety details when available. - Add tests for variety functionality in planting model and serializers.
- Removed the planting_event_icon helper method as it was no longer needed. - Updated CropChip component to accept a label prop for better flexibility in displaying crop names. - Modified PlantingChip component to use the new label prop instead of variety. - Adjusted GardenCard and GardenCards tests to reflect changes in planting structure. - Enhanced PlantingTimeline to utilize markers for event rendering, allowing for more dynamic label positioning. - Updated Planting model to provide a with_variety method for consistent naming. - Refactored serializers to include the new label structure for planting chips. - Improved tests for planting timeline and chips to ensure correct rendering and data handling. - Updated views to align with new timeline and planting structures, ensuring proper display of events and seasons.
Member
Author
|
Two translation fixes coming in the next push to this PR The shared season names (
"Feder" and "Ressort" both mean a mechanical spring, not the season. They look like a machine translation of the English word "spring" without context. The seed packet translations in the same files ( This PR also makes two more places use the shared season names (the garden page header and the dashboard's season line), so the wrong words would have shown there too. No other translations were changed. A German or French speaker is welcome to check. |
The season tints live in one table, used by the weather charts, the
timeline and the suggestions page, and the icons in one map. The garden
header and the dashboard's season line now use the shared translations.
Fixes spring in German ("Feder") and French ("Ressort"), which were the
words for a mechanical spring.
- Added hardiness_found method to Crop and Planting models to determine frost tolerance based on crop lineage. - Updated nursery_seedlings method to include alternate_name in the query. - Improved styling for fact cards in the gardens page and added edit link functionality. - Enhanced serializers to include alternate names and updated expected finish events in planting timelines. - Added localization support for growth degree days and planting events in multiple languages. - Updated tests to reflect changes in planting behavior and ensure accurate display of planting information.
Br3nda
enabled auto-merge
November 14, 2026 20:51
CloCkWeRX
approved these changes
Nov 15, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A new fact card on the planting page shows the growing degree days a planting has had, out of how many the crop needs.
https://en.wikipedia.org/wiki/Growing_degree-day
Also in here
Notes
Assisted by Claude