Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adding raw ores to GTCEu 1.12.2 as both GTNH and GT Modern have Raw Ores but CEu doesn't
Implementation Details
This was originally implemented on the 2.8.10 branch but it compiles and launches on the master branch.
I basically used the PropertyKey and Builder implementation to add the raw ores. I'm by no means an expert programmer but the way I implemented it was pretty simple to do.
Perhaps some extra work could be done such as making raw ores toggleable via a config option and to maybe make single block miners also drop raw ores instead of the ore block itself.
Outcome
Raw ores that allow GregTech Ores to more or less be affected by Fortune tools, granting players a bit more ore for their ore. The oreDict also starts with
oreRawso anything filtered to beore*should be able to pick up the raw ores no problem without needing to edit existing filters. It also works with other mods that add their own ores as well.Using silk touch on the regular Ore Block still provides the original ore block, similar to how vanilla handles it. The drop of raw ores by fortune is also done more or less the same as vanilla with Diamond/Coal ore.
Additional Information
I used the Raw Ore textures from GT Modern as I am terrible at making Textures and it was something that was quick and easy to get going. I will be honest I wasn't entirely sure if I'm allowed to do this or not because of the license but I figured since both projects are owned by the CEu team I figured it would be fine?
The screenshot is how it looks in game, even showing a custom ore added by another mod.
Potential Compatibility Issues
As far as I can tell there doesn't seem to be any compatibility issues and even works with mods adding custom ores. Only thing I could think of that might cause compatibility issues is mods patching the classes I've edited might have a hissy fit but I'm unsure.