Skip to content

Send message using Enter on physical keyboard - #450

Open
RobertoTired wants to merge 3 commits into
GrapheneOS:mainfrom
RobertoTired:main
Open

RobertoTired wants to merge 3 commits into
GrapheneOS:mainfrom
RobertoTired:main

Conversation

@RobertoTired

Copy link
Copy Markdown

Allow sending of message using Enter key on physical keyboard. A parameter toggle has been added to switch between 'Enter to send / Enter + Shift for multiline' and 'Enter for multiline / Ctrl + Enter to send'.

  • AI has been used to generate translation for all languages except English and French, and it help me creating the unit test.
  • I have added a parameter to the top level parameter screen, I can move it where you want.
  • Tested on emulator and also on my physical Pixel 8, both in desktop mode with physical usb keyboard and in regular mode with soft keyboard.
  • If this PR is approved, I will try to fix also small anoying bugs when used in desktop mode (for example using arrow in text field may get the focus out of the text field).
  • Using Shift Enter or Ctrl Enter seems to be a "standard" on other messaging application (Signal and Teams for example).
  • I am quite new in android development (but not in Java), feel free to ask me to change anything (or remove it :))
    Thanks

Allow sending of message using Enter key on physical keyboard. A parameter toggle has been added to
switch between 'Enter to send / Enter + Shift for multiline' and 'Enter for multiline / Ctrl +
Enter to send'.
@RobertoTired

Copy link
Copy Markdown
Author

Not sure how to fix the Instrumented tests (Android 17 x86_64) issue... I run ./gradlew :app:connectedDebugAndroidTest with a local emulator and I got no issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant