Repository navigation
ci: run CI on Go 1.26 with golangci-lint v2 - #14
Merged
Merged
Conversation
Go in CI: 1.22 -> 1.26 (three jobs). golangci-lint: v1.59.1 -> v2.14.0. golangci-lint-action: v6 -> v9. The go directive in go.mod stays 1.22. The config moves to the v2 format. It keeps the goimports local prefix github.com/ory, the test-file exclusions, and the SA1019 exclusion. It uses the v2 exclusion presets that replace the v1 default exclusions. It excludes the gosec rules that upstream Ory excludes, and also G115 and G710. It turns off the staticcheck QF quick-fix checks that v1 did not run. Findings: 4 fixed in code (2 len() nil checks, reflect.Pointer, unused fetchOpenIdConfiguration), 8 marked with nolint and a reason (G703, G407, G602, G124), 1 existing nolint widened (md4 import, G506). One finding remains in selfservice/strategy/oidc/provider_microsoft.go. Claude-Session: https://claude.ai/code/session_0192dFsdvVuQdqMdVxi9HDkz
dmakarenko
force-pushed
the
kratos-ci-go126-lint-v2-20260930
branch
from
September 30, 2026 21:28
ab9b2a7 to
78c499e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs CI on Go 1.26 (the release toolchain) with golangci-lint
v2.14.0(action v9, v2.golangci.ymlbased on upstream Ory, gosec G115/G710 excluded), with 4 code fixes and 8//nolintlines that each give a reason.Why: golangci-lint
v1.59.1cannot type-check on Go 1.26, and the release image (#11) builds with Go 1.26, which CI did not test. Merge after #13: until then lint reports the G107http.Getthat #13 deletes.Tested: golangci-lint v2.14.0 on Go 1.26 reports only that G107 finding.
go build ./...passes.hash,request,schema,xanddriver/configgive 379 pass / 0 fail / 0 skip.https://claude.ai/code/session_0192dFsdvVuQdqMdVxi9HDkz