Repository navigation
Compile only the test group into requirements-test.txt - #22
Merged
Merged
Conversation
requirements-test.txt was compiled from the project plus its test group, so it repeated every production pin. Those are compiled for the Docker image's Python version, and some aren't installable on the next one: in pipe-encounters, grpcio 1.65.5 (pinned by Beam for 3.12) has no 3.13 wheel, so the CI job on 3.13 failed in make install-test while building it from source. make reqs now compiles only the group (--group pyproject.toml:test), still constrained by requirements.txt so the shared packages match production. The test image installs the same test dependencies on top of the production image; the 3.13 job resolves the package's own dependencies with pip install.
tomaslink
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIPELINE-4672 · Fixes the test-dependency setup added in #18.
Summary
requirements-test.txtwas compiled from the project plus itstestgroup, so it repeated every production pin. Those pins are resolved for the Docker image's Python (3.12), and some aren't installable on the next version: in pipe-encounters, Beam pins grpcio 1.65.5, which has no 3.13 wheel, so the CI job on 3.13 failed inmake install-testwhile trying to build it from source.make reqs/make reqs-upgradenow compile only the test group (--group pyproject.toml:test), still constrained byrequirements.txtso the shared packages (e.g.packaging,pluggy) match production.requirements-test.txtgoes from the full dependency tree to the 8 test packages.pip install .).Verification
make reqsandmake docker-test(11 passed).make install-test,pip install .,pytest) now passes (17 tests), where before it failed building grpcio.--group pyproject.toml:test.🤖 Generated with Claude Code