Repository navigation
Drop the type: ignore comments now that gfw-common ships py.typed - #21
Merged
Merged
Conversation
gfw-common 0.20.3 ships a py.typed marker, so mypy uses its type hints and the example CLI's subclasses of Command and PipelineConfig no longer need type: ignore[misc]. Bump gfw-common to ~=0.20.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIPELINE-4674 · Follow-up to #19 and GlobalFishingWatch/gfw-common#100.
Summary
gfw-common 0.20.3 ships a
py.typedmarker, so mypy now uses its type hints. The example CLI's subclasses ofCommandandPipelineConfigno longer need# type: ignore[misc], and calls into gfw-common are type-checked.type: ignore[misc]comments and their notes.gfw-commonto~=0.20.3and recompile the requirements (make reqs).Verification
mypy(strict): no issues, without the ignores (with 0.20.2 it reportedClass cannot subclass "Command" (has type "Any")and the same forPipelineConfig).pytest: 18 passed;flake8,ruff: clean.make docker-build && make docker-test: passes; the production image has gfw-common 0.20.3.🤖 Generated with Claude Code