Skip to content

fix(Python): force binding of attribute to be optional - #1340

Merged
BotellaA merged 1 commit into
nextfrom
fix/nullable_python_bindings
Oct 7, 2026
Merged

BotellaA merged 1 commit into
nextfrom
fix/nullable_python_bindings

Conversation

@BotellaA

@BotellaA BotellaA commented Oct 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@BotellaA
BotellaA requested a review from BenPinet October 7, 2026 11:45
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 4 concern(s)
  • bindings/python/src/basic/attribute_manager.cpp:37:10: warning: [cppcoreguidelines-avoid-non-const-global-variables]

    variable 'python_attribute_class' is non-const and globally accessible, consider making it const

       37 |     void python_attribute_class( pybind11::class_< AttributeManager >& manager,
          |          ^
  • bindings/python/src/basic/attribute_manager.cpp:37:10: warning: [misc-use-internal-linkage]

    variable 'python_attribute_class' can be made static or moved into an anonymous namespace to enforce internal linkage

       37 |     void python_attribute_class( pybind11::class_< AttributeManager >& manager,
          |          ^
          |     static 
  • bindings/python/src/basic/attribute_manager.cpp:118:10: warning: [misc-use-internal-linkage]

    function 'python_attribute_time_series_class' can be made static or moved into an anonymous namespace to enforce internal linkage

      118 |     void python_attribute_time_series_class(
          |          ^
          |     static 
  • bindings/python/src/basic/attribute_manager.cpp:135:10: warning: [misc-use-internal-linkage]

    function 'define_attribute_manager' can be made static or moved into an anonymous namespace to enforce internal linkage

      135 |     void define_attribute_manager( pybind11::module& module )
          |          ^
          |     static 

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit 5d54574 into next Oct 7, 2026
24 checks passed
@BotellaA
BotellaA deleted the fix/nullable_python_bindings branch October 7, 2026 12:42
@BotellaA

BotellaA commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 18.4.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

BotellaA commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 18.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants