Skip to content

fix(Attribute): change no_value to optional - #198

Merged
BotellaA merged 2 commits into
nextfrom
fix/optional-no-value
Oct 9, 2026
Merged

BotellaA merged 2 commits into
nextfrom
fix/optional-no-value

Conversation

@BotellaA

@BotellaA BotellaA commented Oct 8, 2026

Copy link
Copy Markdown
Member

AttributeValues::no_value is now a std::optional: when empty, every element has a value (has_value() returns true).

  • Removes no_value = {} assignments and no_value on bool attributes.
  • Rebuild required: this changes the ABI of AttributeValues.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BotellaA
BotellaA requested a review from BenPinet October 8, 2026 12:10
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit 7e9c999 into next Oct 9, 2026
62 of 74 checks passed
@BotellaA
BotellaA deleted the fix/optional-no-value branch October 9, 2026 06:05
@BotellaA

BotellaA commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 6.12.2-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 6.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants