Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignoring missing observations currently fails when per-observation measurement errors or external drifts accompany them:
This raises
krige.cond_err: wrong number of measurement errors.The positions and values are filtered, but the corresponding error entries remain. External drifts have the same mismatch. Apply the finite-value mask to full-length metadata, while retaining support for already filtered arrays and scalar/nugget errors.Regressions cover both metadata types, multiple drifts, refreshes, NaN/infinity, unchanged input arrays and malformed metadata. The full suite passes (215 tests and 17 subtests; two existing PyVista skips), as do source/benchmark Ruff checks and wheel/sdist builds.
A separate audit with the bundled DWD measurements withholds station observations and checks interpolation against explicit filtering and independently assembled covariance equations. All 18 previously failing calls recover 1,152 predictions within 3.59e-13 of the dense reference; the 36 explicit-filter/already-filtered control paths remain identical. #422's current head still reproduces both errors.