Repository navigation
👷 ci: key main's concurrency group on push events only - #78
Merged
nstarman merged 2 commits intoOct 10, 2026
Merged
Conversation
Append the SHA only for push events (which only fire on main), so PRs, releases and manual runs keep their exact previous group names with no trailing '-'. Use an explicit folded scalar (>-) so the wrapped expression reads unambiguously as one string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 3
Lines ? 75
Branches ? 0
========================================
Hits ? 75
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Not every workflow runs on releases or manual triggers; say "all other events" so the comment stays accurate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #76, based on review feedback on the matching PRs in other GalacticDynamics repos.
#76 added
-${{ github.ref == 'refs/heads/main' && github.sha || '' }}to the concurrency group. That had two side effects:maingroup name gained a trailing-, so the first PR push after the merge didn't cancel runs started under the old name;mainalso became uncancellable.The group is now
…-${{ github.event_name == 'push' && github.sha || github.ref }}. Push triggers only fire onmain, so each merge still gets its own run, and every other event keeps the exact group name it had before #76. The value is also written as an explicit>-folded scalar, so the wrapped line can't be misread.Files:
.github/workflows/cd.yml,.github/workflows/ci.yml🤖 Generated with Claude Code