Repository navigation
📝 docs: keep the logo script out of the built docs - #37
Merged
Merged
Conversation
html_static_path copies everything in docs/_static/, so make_logo.py was published as _static/make_logo.py. exclude_patterns also filters that copy; the pattern needs the **/ prefix, since Sphinx matches a top-level static file as ./make_logo.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 7 7
Lines 67 67
=======================================
Hits 63 63
Misses 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
html_static_path = ["_static"]copies everything indocs/_static/, so the logo generator added in #36 was published alongside the docs as_static/make_logo.py. Harmless, but it isn't part of the site.exclude_patternsalso filters the static copy, so this adds"**/make_logo.py"to it. The**/is needed: Sphinx'scopy_assetmatches a top-level static file as./make_logo.py, which a baremake_logo.pydoesn't match.Checked: a local docs build publishes
_static/favicon.svg, which is still the favicon and sidebar logo, and nomake_logo.py. pre-commit passes ondocs/conf.py.The same fix was made in cosmology-api/cosmology.api#145, after a review there noticed it.
🤖 Generated with Claude Code