Repository navigation
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
============================================
- Coverage 71.89% 71.48% -0.42%
Complexity 252 252
============================================
Files 168 208 +40
Lines 23200 25051 +1851
Branches 826 1156 +330
============================================
+ Hits 16680 17907 +1227
- Misses 6437 6974 +537
- Partials 83 170 +87
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the native Ping SDK dependencies across all packages to 2.2.0 on both platforms and resolves the two API changes the bump surfaced. All Android
com.pingidentity.sdks:*artifacts move from 2.1.0 to 2.2.0 (rn-journeynormalizes off the2.2.0-beta2pin), all iOSPing*pods move from 2.1.0 to 2.2.0, and the temporary develop-commit pin in both iOS Podfiles is removed. With every pin converged on one version, the native SDK version consistency gate is active again.Changes
2.1.0→2.2.0in all 15 packagebuild.gradlefiles plus the sample app's directprotectpin (2.0.1→2.2.0); iOS2.1.0→2.2.0in all 15RNPing*.podspecfiles.rn-push'sPingLoggernormalizes from a~>range to an exact pin so the version gate sees one consistent set.ping_ios_developpin block fromPingSampleAppandPingTestRunner(its removal condition, the iOS release containing SDKS-5156, is satisfied by 2.2.0); restores the threePingExternalIdP*provider pods in the sample app at 2.2.0; drops the deadRecaptchaInterop/GoogleUtilitiesblock from the test runner; regenerates bothPodfile.lockfiles against trunk at 2.2.0.FidoClientConfig.useFido2Client(undeclared breaking change). The bridge now applies the override asFidoAuthenticateCustomizer.useFido2ApiClientper call, so it reaches standaloneauthenticate,authenticateForJourney, andauthenticateForDaVinci(SDKS-5515).saveCredentialto fetch-then-patch. Android SDK 2.2.0 addedrequire(secret.isNotBlank())toOathCredential's init, which rejected the empty-secret credential the bridge built from the JS payload before fetching the stored record. The decode now reads onlyid,displayIssuer, anddisplayAccountName; everything else comes from the stored credential.FidoAndroidConfig.useFido2Clientrenamed touseFido2ApiClient; TSDoc and rn-fido README updated to describe the authentication-only scope.useFido2ApiClient.native-sdk-versionspre-commit check (disabled in SDKS-5380 while pins were divergent); removes the SDKS-5296 workaround notes from the browser/oidc Gradle files, verified fixed in 2.2.0 upstream; drops two duplicateFileTimestampentries from the test runner privacy manifest.@ping-identity/rn-fidominor,@ping-identity/rn-oathpatch.Platform notes
useFido2ApiClientis authentication-only: 2.2.0register()always uses Credential Manager and has no API selection. With no override set, native auto-detection applies (Play Services when GMS is present), which matches 2.1.0 behavior for apps that never set the flag.android: { useFido2Client: true }will silently stop applying the override on Android; the key must be renamed.2.2.0-beta2and2.2.0final are functionally identical (sources differ only inBuildConfig), so the beta-to-final normalization is not a behavior change.build.gradleand podspec pins in lockstep.Verification
check-native-sdk-versions.mjs: all 30 files pinned to 2.2.0RNPing*-Unit-Testsschemes, 0 failures, iPhone 16 / iOS 18.6, pods at 2.2.0)