Skip to content

Validate instance editor setting types - #9211

Open
n-lark wants to merge 1 commit into
mainfrom
185-serialize
Open

n-lark wants to merge 1 commit into
mainfrom
185-serialize

Conversation

@n-lark

@n-lark n-lark commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

Tightens validation of instance and template editor settings:

  • debugMaxLength is now checked and stored as a number
  • text settings only accept strings
  • disableEditor only accepts a boolean
  • the HTTP node CORS origin is stored in its normalized form.

Values restored from snapshots or pipelines that don't pass are dropped rather than failing the restore.

Part of a two-part change with FlowFuse/nr-launcher#677, which updates how these settings are written into the Node-RED settings file. The two PRs can be merged independently.

Related Issue(s)

Relates to https://github.com/FlowFuse/security/issues/185

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.73%. Comparing base (b0e755f) to head (9b0a110).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9211      +/-   ##
==========================================
+ Coverage   80.71%   80.73%   +0.02%     
==========================================
  Files         477      477              
  Lines       26380    26401      +21     
  Branches     7025     7036      +11     
==========================================
+ Hits        21292    21315      +23     
+ Misses       5088     5086       -2     
Flag Coverage Δ
backend 80.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

1 active deployment
staging — 9b0a1104 Deployed Nov 16, 2026 by n-lark via Deploy application #13131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant