Repository navigation
Show that a table is loading when switching tables in the Tables explorer - #9159
Merged
Merged
Conversation
cstns
force-pushed
the
9158-tables-loading-state
branch
from
November 11, 2026 14:50
d09746a to
c5ab0b7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 9155-tables-explorer-scrolling #9159 +/- ##
=================================================================
Coverage ? 80.61%
=================================================================
Files ? 477
Lines ? 26331
Branches ? 7012
=================================================================
Hits ? 21227
Misses ? 5104
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andypalmi
approved these changes
Nov 11, 2026
cstns
force-pushed
the
9158-tables-loading-state
branch
from
November 12, 2026 09:07
c5ab0b7 to
66e88e9
Compare
…orer Picking a table gave no sign that it was loading. A table that hadn't been opened yet said there was nothing there until its columns arrived, then showed headers with no rows until the rows did. The data area now shows a loading indicator while the columns aren't known, then skeleton rows under the real headers while the rows load, and only says there is nothing to show once loading is done. Changing page and Refresh use the same skeleton rows.
cstns
force-pushed
the
9158-tables-loading-state
branch
from
November 13, 2026 10:42
66e88e9 to
4fe80d1
Compare
Contributor
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #9158
Stacked on #9156.
Clicking a table in the Tables explorer gave no sign that it was loading. A table that hadn't been opened yet showed "There doesn't seem to be anything here!" until its columns arrived, then the headers with no rows until the rows did, which on a slow connection reads as an empty or broken table. A table opened earlier showed its old rows and swapped them without warning once the fresh ones landed.
The data area is now in a loading state from the click until the rows are in. While the table's columns aren't known yet it shows a loading indicator, and once they are it shows skeleton rows under the real headers, the same loading style the instances list has. The "nothing here" message only shows when loading is done and there's really nothing to show. Changing page and Refresh use the same skeleton rows instead of the plain "Loading..." line.
If another table is picked before the first one has finished, the first one finishing doesn't end the loading state, the one being looked at does. A table that fails to load ends it too.
Covered by the rows list spec. Also checked in the browser with 1.5s of latency added to every request: first open of a table, reopening one, and clicking two tables 0.3s apart.