Skip to content

Show that a table is loading when switching tables in the Tables explorer - #9159

Merged
cstns merged 1 commit into
9155-tables-explorer-scrollingfrom
9158-tables-loading-state
Nov 16, 2026
Merged

cstns merged 1 commit into
9155-tables-explorer-scrollingfrom
9158-tables-loading-state

Conversation

@cstns

@cstns cstns commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Closes #9158

Stacked on #9156.

Clicking a table in the Tables explorer gave no sign that it was loading. A table that hadn't been opened yet showed "There doesn't seem to be anything here!" until its columns arrived, then the headers with no rows until the rows did, which on a slow connection reads as an empty or broken table. A table opened earlier showed its old rows and swapped them without warning once the fresh ones landed.

The data area is now in a loading state from the click until the rows are in. While the table's columns aren't known yet it shows a loading indicator, and once they are it shows skeleton rows under the real headers, the same loading style the instances list has. The "nothing here" message only shows when loading is done and there's really nothing to show. Changing page and Refresh use the same skeleton rows instead of the plain "Loading..." line.

If another table is picked before the first one has finished, the first one finishing doesn't end the loading state, the one being looked at does. A table that fails to load ends it too.

Covered by the rows list spec. Also checked in the browser with 1.5s of latency added to every request: first open of a table, reopening one, and clicking two tables 0.3s apart.

@cstns cstns self-assigned this Nov 11, 2026
@cstns
cstns added this pull request to stack #9154 November 11, 2026 14:45
@cstns
cstns force-pushed the 9158-tables-loading-state branch from d09746a to c5ab0b7 Compare November 11, 2026 14:50
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (9155-tables-explorer-scrolling@52a6ff8). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             9155-tables-explorer-scrolling    #9159   +/-   ##
=================================================================
  Coverage                                  ?   80.61%           
=================================================================
  Files                                     ?      477           
  Lines                                     ?    26331           
  Branches                                  ?     7012           
=================================================================
  Hits                                      ?    21227           
  Misses                                    ?     5104           
  Partials                                  ?        0           
Flag Coverage Δ
backend 80.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cstns
cstns requested a review from andypalmi November 11, 2026 15:23
@cstns
cstns marked this pull request as ready for review November 11, 2026 15:23
@cstns
cstns force-pushed the 9158-tables-loading-state branch from c5ab0b7 to 66e88e9 Compare November 12, 2026 09:07
…orer

Picking a table gave no sign that it was loading. A table that hadn't been opened yet said there was nothing there until its columns arrived, then showed headers with no rows until the rows did. The data area now shows a loading indicator while the columns aren't known, then skeleton rows under the real headers while the rows load, and only says there is nothing to show once loading is done.

Changing page and Refresh use the same skeleton rows.
@cstns
cstns force-pushed the 9158-tables-loading-state branch from 66e88e9 to 4fe80d1 Compare November 13, 2026 10:42
@cstns

cstns commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

What to look at: switching to another table. The new table's columns show straight away with placeholder rows until its data arrives, where before the previous table's rows stayed on screen.

9159-loading-when-switching-tables

@cstns
cstns merged commit 3acec4e into main Nov 16, 2026
50 of 67 checks passed
@cstns
cstns deleted the 9158-tables-loading-state branch November 16, 2026 13:27

This branch was successfully deployed

1 active deployment
staging — 4fe80d1d Deployed Nov 16, 2026 by cstns via Remove application #13098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tables UI: show that a table is loading when switching between tables

2 participants