Repository navigation
Don't pre-generate the pattern on wandering trader scrolls - #1363
Open
Robotgiggle wants to merge 5 commits into
Open
Robotgiggle wants to merge 5 commits into
Robotgiggle wants to merge 5 commits into
Conversation
s5bug
reviewed
Nov 2, 2026
| val perWorldKeys = mutableListOf<ResourceKey<ActionRegistryEntry>>() | ||
| val regi = IXplatAbstractions.INSTANCE.getActionRegistry() | ||
| for (key in regi.registryKeySet()) { | ||
| if (isOfTag(regi, key, HexTags.Actions.PER_WORLD_PATTERN)) { |
Contributor
There was a problem hiding this comment.
Is there not a better way to get all the entries of a tag??
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceKeys for all the great spells" behavior out of various places and into HexUtils to avoid reusing the exact same code in three different places.Ancient Scroll of <spell>rather thanHow did you get this item of <spell>since packmakers should be able to use other sizes if they want to.