[s5bug]

Includes various translation PRs, as well as:

• Only check for enlightenment when drawing outside parens #1290
• Make impulse cost calculation respect max magnitude #1307
• fix: retain velocity after teleportation #1310
• Add media costs to EMI flay mind recipes #1323
• Tweak OpLightning implementation #1304
• Prevent variable-cost spells being made free with very small inputs #1308
• Allow anything with the right NBT to shift-scroll #1329
• Specify Modrinth dependency versions based on gradle.properties #1319
• Ignore nonexistent actions when loading Great Spells from world data #1335
• Sync Sentinel, Pigment and Altiora state correctly on Forge #1331
• Add contribution policy #1349
• Fix typo in continuation key #1350
• Fix thoth consuming one extra op per iteration #1352

As before, the changelog updates have not been included (they will be merged in upon the release of 0.11.5).

[Robotgiggle]

Functionality is mostly good, but can this wait until #1331 gets merged and then include that? (if the author doesn't get back to me about the sentinel thing by tomorrow or so, I'm just gonna test ingame to make sure nothing breaks and then merge it)

Also, see the tweaks below for the shift-scrolling feature.

[Robotgiggle]

Also, this is definitely the sort of thing that should have its own PR, but (in the same vein as the shift scrolling changes) what do you think about changing IXplatAbstractions.INSTANCE.findDataHolder such that any stack with the IOTA_HOLDER_IOTA or SPELLBOOK_PAGES + SELECTED_SPELLBOOK_PAGE components works as a read-only iota holder even if it doesn't actually implement the interface or provide its own read/write methods?

[Robotgiggle]

#1306, #1319 and #1335 have just gone in, so those should probably get included here too.

[s5bug]

Will do tmw :D

[s5bug]

Now includes #1319, #1335, #1331, #1349, #1350, #1352, and changes have been addressed

[Robotgiggle]

#1319 updated the patchouli dependency to version 85, and the relevant changes to fabric.mod.json and the top-level gradle.properties don't seem to have made it in here.

Also, the change from #1319 to use variables in the modrinthDependencies section has not made it into the NeoForge build.gradle.

Finally, the change to Thoth's Gambit from #1352 that makes it skip iteration entirely if the pattern list is empty has not made it in here, which is somewhat understandable since thoth is completely different in 1.21. I've made and tested a 1.21-compatible version of the additional code for thoth, so you should just be able to stick the following chunk of code in between lines 50 and 52 of SpecialHandlerForEach.kt to replicate the change from #1352.

// if the pattern list is empty, directly return the modified data list to avoid VM overhead
// note that we still need to include a copy of the context stack before each datum
if (instrList.isEmpty()) {
    val outList = mutableListOf<Iota>()
    for (datum in datums) {
        outList.addAll(contextStack.appended(datum))
    }
    val image2 = image.withUsedOp().copy(stack = stashedStack.appended(ListIota(outList)))
    return OperationResult(image2, listOf(), continuation, HexEvalSounds.THOTH.get())
}

[s5bug]

1. ver 85 isn't available for 1.21 so I've moved all the numbers to 88
2. fixed
3. fixed

[Robotgiggle]

As mentioned in discord, changing the Modrinth version numbers without changing the URLs has broken the automatic tests.

Also, when I said to include the update-to-version-85 changes, I didn't realize that the 1.21 branch was already using a much higher Patchouli version. It should be fine to keep it at 93 - just make sure everything actually agrees on the same version and uses the gradle variable when possible.

[Robotgiggle]

All looks good now!