Repository navigation
docs(cli): replace legacy droid exec tool flags with --only-tools/--add-tools/--remove-tools - #74
Closed
lukealvoeiro wants to merge 1 commit into
Closed
lukealvoeiro wants to merge 1 commit into
lukealvoeiro wants to merge 1 commit into
Conversation
…dd-tools/--remove-tools Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
Droid finished @lukealvoeiro's task —— View job LGTM. No actionable issues found in the documentation updates. 0 inline comments posted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap
EXEC-22 / DOC-2 / EXEC-60 (docs make a command fail, P2). The docs teach hidden legacy tool-selection flags (
--restrict-tools,--additional-tools,--disabled-tools), and the CLI reference examples use a tool ID (Bash) that does not exist, so they fail at startup.Evidence
docs/reference/cli-reference.mdx:130-132(JP:62-64):droid exec --restrict-tools ApplyPatch,Bash,droid exec --additional-tools ApplyPatch,Bashdocs/cli/droid-exec/overview.mdx:66-68(JP:65-67): help block lists the legacy flags;:376-382(JP:336-342) uses them in examplesdocs/cli/configuration/mcp.mdx:443(EN and JP): says MCP filtering mirrors--restrict-tools/--disabled-toolsapps/cli/src/entrypoints/exec/command.ts:109-126defines the visible--only-tools,--add-tools,--remove-tools; lines127-150keep--enabled-tools,--additional-tools,--disabled-tools,--restrict-toolswith.hideHelp().apps/cli/src/commands/resolveToolSelection.ts:413-416throwsUnknown tool identifier(s).droid exec --list-toolslistsExecute; there is noBashtool.Why it matters
The CLI reference examples fail as written, and the flags the docs teach are hidden from
droid exec --help, so users cannot discover the supported ones from the docs.Fix
--restrict-tools,--additional-tools,--disabled-toolswith--only-tools,--add-tools,--remove-toolsin the help block, examples and both reference tables (EN and JP), and in the MCP filtering note.BashID withExecute(ApplyPatchandexecute-cliare valid and kept).droid exec --helptext.Validation
Every new example run against the source-built CLI (offline, so a run that passes flag validation stops at the model connection):
After the change,
docs/(EN and JP) has no remainingrestrict-tools,additional-tools,disabled-toolsorApplyPatch,Bash.Found by the scheduled CLI arguments audit.