test: guard the declaration shape that keeps tree schemas re-exportable - #67
Merged
Merged
Conversation
A consumer re-exporting z.array(PredicateNodeSchema) without an annotation hit TS7056 when the declaration bundler emitted bare declarations plus a trailing export list. Assert every top-level declaration in the built tree declarations is exported in place.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in trilean@1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TS7056 failure reported in this issue depended on how the declaration bundler emitted
dist/tree.d.ts: 1.6.2 (tsdown 0.22) wrote baredeclare const Xplus a trailingexport { ... }list, and a consumer re-exportingz.array(PredicateNodeSchema)then failed. Since the tsdown 0.23 bump (1.6.3) the declarations areexport declare const Xand the unannotated re-export builds.This adds a smoke test asserting that
dist/tree.d.tsanddist/tree.d.ctsexport both schemas in place, with no bare top-level declarations and no trailing export list, so a bundler change that brings the old shape back fails here rather than in a consumer.Fixes #62