Skip to content

Hide the swap provider picker for a single quote - #6325

Open
j0ntz wants to merge 1 commit into
developfrom
jon/swap-solo-provider-no-modal
Open

j0ntz wants to merge 1 commit into
developfrom
jon/swap-solo-provider-no-modal

Conversation

@j0ntz

@j0ntz j0ntz commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Description

Asana task

When only one swap quote comes back (for example Bridgeless for BTC to BTCx), the Select Swap Provider modal had nothing to offer except the same quote listed twice, once as the Selected Quote and again under Fixed or Variable Quotes.

The confirmation scene now passes onPress to the Powered by card only when there is more than one quote. With a single quote the card is static: tapping it does nothing, and it shows no chevron and no "Tap to Change Provider" hint. Stealth Swap keeps its existing fixed-provider behavior. The check counts quotes rather than distinct providers, because one provider returning two quotes is still a real choice.

Tests: two new SwapConfirmationScene cases (a single quote leaves the card without onPress or the hint; two quotes keep both), plus the updated snapshot.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Low Risk
UI-only change on swap confirmation with no impact on quote selection logic or transaction execution.

Overview
Swap confirmation no longer treats the Powered by card as tappable when there is only one quote, so users are not sent to a provider picker that duplicated the same option.

The scene now sets canChangeProvider when the swap is not Stealth and quotes.length > 1, and passes onPress to PoweredByCard only in that case. With a single quote the card stays static (no chevron or “Tap to Change Provider”), matching fixed-provider Stealth swaps. The rule uses quote count rather than distinct providers so two quotes from one provider still allow switching.

Tests cover single- vs multi-quote behavior; the snapshot reflects the non-interactive card layout.

Reviewed by Cursor Bugbot for commit d3fa637. Bugbot is set up for automated code reviews on this repo. Configure here.

Test evidence

d3fa637
Hide the swap provider picker for a single quote
2026-11-05

1. multi quote tappable

2. multi quote picker opens

3. single quote static card

4. single quote tap does nothing

The Select Swap Provider modal listed the same quote twice when only
one provider answered (Selected Quote plus its Fixed or Variable
section). With a single quote there is nothing to choose, so the
Powered by card is now static: tapping it does nothing and it shows no
chevron or Tap to Change Provider hint, as Stealth Swap already does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant