Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The address explorer was only reachable by tapping the address on the Receive scene, which nothing in the UI advertises. The wallet menu now has an explicit entry on non-privacy wallets that have an explorer template, opening the wallet's current receive address. Privacy chains stay hidden even when they ship a template (monero and zcash do), as do keys-only plugins. Tokens get the entry too and open their parent wallet's address.
j0ntz
force-pushed
the
jon/wallet-menu-view-in-explorer
branch
from
November 5, 2026 20:25
0b1ed97 to
9158389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Adds a "View in Explorer" entry to the wallet menu (the kebab menu on Wallet Details). Until now the only way to reach a wallet's address on a block explorer was to tap the address on the Receive scene, which nothing in the UI advertises.
getAddresses, the same one the Receive scene shows. UTXO wallets open their current receive address, not a whole-wallet view.0.0.<public key>placeholder that Hashscan rejects as invalid. The entry shows a "No Account Yet" modal instead of opening Hashscan. Once the account exists (numeric0.0.<number>id), it opens Hashscan as usual.Wallet List rows open this same modal, by long press or by the swipe menu. The entry appears there as well.
Testing on the iOS simulator: tapped the entry on BTC and ETH wallets and on a USDC token. Safari's history recorded
mempool.space/address/<address>andetherscan.io/address/<address>, and the BTC address equals the one on the Receive scene. The USDC tap opened its parent ETH address. Etherscan stopped at its Cloudflare human check on the simulator. The entry is absent on Monero and Pirate wallets and shows when a Wallet List row is long pressed. Zano and Zcash wallets were not driven; unit tests cover their eligibility and the opened URL.QA retest of the unfunded Hedera case: on a new 0 HBAR wallet the entry shows the "No Account Yet" modal (frames 10 to 12), OK closes it, and Edge stays in front with no Safari launch. Unit tests cover both the placeholder address and a numeric account id.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
9158389Add View in Explorer to the wallet menu
2026-11-05
1. eth menu entry
2. monero menu no entry
3. eth opens etherscan cloudflare check
4. usdc token menu entry
5. btc menu entry
6. btc opens mempool address page
7. pirate menu no entry
8. btc receive same address
9. wallet list menu entry
10. c3 hedera wallet menu
11. c3 no account yet modal
12. c3 stays in edge after ok