Skip to content

fix: end_shipper_id param - #670

Merged
Justin Hammond (Justintime50) merged 1 commit into
masterfrom
669_end_shipper_id
Sep 30, 2026
Merged

Justin Hammond (Justintime50) merged 1 commit into
masterfrom
669_end_shipper_id

Conversation

@Justintime50

@Justintime50 Justin Hammond (Justintime50) commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Description

  • Correctly passes end_shipper_id param instead of end_shipper in shipment buy calls (closes 669)

Testing

Re-recorded cassettes

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50
Justin Hammond (Justintime50) merged commit 34a0502 into master Sep 30, 2026
19 checks passed
@Justintime50
Justin Hammond (Justintime50) deleted the 669_end_shipper_id branch September 30, 2026 17:08
Justin Hammond (Justintime50) added a commit that referenced this pull request Oct 1, 2026
# Description

- Correctly passes `end_shipper_id` param instead of `end_shipper` in
shipment buy calls (closes
[669](#669))
<!-- Please provide a general summary of your PR changes and link any
related issues or other pull requests. -->

# Testing

Re-recorded cassettes

<!--
Please provide details on how you tested this code. See below.

- All pull requests must be tested (unit tests where possible with
accompanying cassettes, or provide a screenshot of end-to-end testing
when unit tests are not possible)
- New features must get a new unit test
- Bug fixes/refactors must re-record existing cassettes 
-->

# Pull Request Type

Please select the option(s) that are relevant to this PR.

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Improvement (fixing a typo, updating readme, renaming a variable
name, etc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Shipment.Buy sends EndShipperId as "end_shipper" instead of "end_shipper_id"

3 participants