Skip to content

[feat] Add surcharge model updates - #580

Merged
Justin Hammond (Justintime50) merged 3 commits into
masterfrom
surcharges
Oct 1, 2026
Merged

[feat] Add surcharge model updates#580
Justin Hammond (Justintime50) merged 3 commits into
masterfrom
surcharges

Conversation

@nwithan8

@nwithan8 Nate Harris (nwithan8) commented Aug 7, 2024 •
edited by Justintime50
Loading

Copy link
Copy Markdown
Contributor

Description

Revives this PR on the latest master and completes surcharge model parity updates.

  • Rebased PR branch onto current master
  • Moved the surcharge changelog note into the newest Next Release section
  • Added Category to EasyPost.Models.API.Surcharge
  • Corrected Surcharge.Amount JSON mapping to amount
  • Keeps Rate.Surcharges and Beta.StatelessRate.Surcharges support

Testing

  • dotnet build EasyPost.sln -nologo
    • Build passed locally
    • Existing repository warnings only (no new errors introduced)

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8
Nate Harris (nwithan8) requested a review from a team August 7, 2024 16:50
@Justintime50
Justin Hammond (Justintime50) marked this pull request as draft August 7, 2024 19:28
@Justintime50

Justin Hammond (Justintime50) commented Jan 9, 2025

Copy link
Copy Markdown
Member

Shelving for now due to prioritization

@Justintime50 Justin Hammond (Justintime50) changed the title [chore] Add Surcharge model [feat] Add surcharge model updates Oct 1, 2026
@Justintime50
Justin Hammond (Justintime50) marked this pull request as ready for review October 1, 2026 16:06
github-advanced-security[bot]
github-advanced-security Bot found potential problems Oct 1, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml Fixed
Comment thread .github/workflows/ci.yml Fixed
@Justintime50
Justin Hammond (Justintime50) merged commit bd4cce7 into master Oct 1, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenjwatkins Stephen Watkins (stephenjwatkins) stephenjwatkins approved these changes
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nwithan8 @Justintime50 @stephenjwatkins @github-advanced-security