Skip to content

ctsm5.4.XXX: 1850 cmip7 cesm3 DATM - #4250

Open
ekluzek wants to merge 3 commits into
ESCOMP:masterfrom
ekluzek:1850_cmip7_cesm3_datm_chem_con
Open

ekluzek wants to merge 3 commits into
ESCOMP:masterfrom
ekluzek:1850_cmip7_cesm3_datm_chem_con

Conversation

@ekluzek

@ekluzek ekluzek commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

Update 1850 compsets to point to the new CMIP7 CO2, aerosols to the latest climatology from the coupled spinup simulations.

Base it on this simulation:

NCAR/LMWG_dev#183

This replaces #4008

Specific notes

Contributors other than yourself, if any

CTSM issues resolved or otherwise addressed, if any:

If answers are expected to change, describe (delete this line otherwise):
Yes! for all 1850 compsets

Any user interface changes (namelist or namelist defaults changes)?
namelist changes for DATM

Testing planned or performed, if any:

  • aux_clm on Derecho
  • aux_clm on Izumi
  • ctsm_sci on Derecho

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s):
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: c
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe: ?
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?:

@ekluzek ekluzek added this to the ctsm6.0.0 (code freeze) milestone Oct 8, 2026
@ekluzek ekluzek self-assigned this Oct 8, 2026
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science usability Improve or clarify user-facing options non-b4b Changes answers (incl. adding tests) test: aux_clm Pass aux_clm suite before merging test: ctsm_sci Run and check ctsm_sci suite before merging labels Oct 8, 2026
@ekluzek

ekluzek commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

Page 178 of the 2nd addition of NR just lists mathematical equations and doesn't have code that goes with it.

https://s3.amazonaws.com/nrbook.com/book_F210.html

Comment thread python/ctsm/cplhist/daily_to_monthly_clim.py Outdated
Comment thread python/ctsm/cplhist/daily_to_monthly_clim.py Outdated
Comment thread python/ctsm/cplhist/daily_to_monthly_clim.py Outdated

@slevis-lmwg slevis-lmwg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erik and I talked about making it clear that

  • this code is specific to aerosols at the moment and
  • we will use in 1850 cases

...by updating the tool name and by including info in the docstrings.

@github-project-automation github-project-automation Bot moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Oct 12, 2026
@ekluzek

ekluzek commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

@slevis-lmwg and I met and went over some of the big picture stuff with this one. I'm going to rebase this one to b4b-dev. Because the thing in here now is just the script to handle aerosols. Then once on b4b-dev I'll create the file and make a new PR that brings in the CDEPS update to point to the new file.

@ekluzek

ekluzek commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor Author

Rebasing to b4b-dev still included the update to ctsm5.4.063. This is even though the branch was started before ctsm5.4.063 was done. This is the kind of case I would think the rebase would work on. But, looking at the branch it didn't include the merge commit which is likely the problem here. So I'll remove the changes to bring the new script in and leave this here for the CDEPS changes that will be coming.

I'll cherry-pick my commits on this branch to a new branch started off of b4b-dev and then that will have just the new dataset changes.

Or alturnatively if I include the merge commit in the branch, the rebase should function normally...

ctsm5.4.063: Move CTSM tests from t232 to t233

Updating testlist_clm.xml, ExpectedTestFails.xml, config_compsets.xml, and documentation that needs updating.

NB: Moving tests from t232 to t233 but postpone the change for LII2 tests (issue ESCOMP#4245).

Changes answers relative to the baseline, only for cases with grids that changed to the t233 grid, and only due to the grid update.

PR ESCOMP#4223
Resolves issue ESCOMP#4238 by removing NorESM test
Contributes to ESCOMP#2540 Move testing from POP to MOM masks
@ekluzek
ekluzek force-pushed the 1850_cmip7_cesm3_datm_chem_con branch from 7bcb2ed to 9bd6ad5 Compare October 14, 2026 17:12
@wwieder

wwieder commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Page 178 of the 2nd addition of NR just lists mathematical equations and doesn't have code that goes with it.

https://s3.amazonaws.com/nrbook.com/book_F210.html

Is this on the correct PR?

@wwieder

wwieder commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@ekluzek is this ready for testing / review, or still in progress

@slevis-lmwg slevis-lmwg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with keeping as three separate PRs (aerosol, o3, co2) or merging as one PR. Erik and I agreed that it's probably safest to do the minimum required changes and leave aspirational/exploratory ideas for a separate PR to avoid delays.

@ekluzek ekluzek changed the title 1850 cmip7 cesm3 DATM ctsm5.4.XXX: 1850 cmip7 cesm3 DATM Oct 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability non-b4b Changes answers (incl. adding tests) science Enhancement to or bug impacting science test: aux_clm Pass aux_clm suite before merging test: ctsm_sci Run and check ctsm_sci suite before merging usability Improve or clarify user-facing options

Projects

Status: In progress - master
Status: In Progress

Development

Successfully merging this pull request may close these issues.

CDEPS update to new CMIP7 preliminary spinup: aerosols, ndep, ozone, CO2

3 participants