Skip to content

fix(biogeophys): Remove leftover gccanopy remnants in CanopyStateType.F90 - #4235

Merged
samsrabin merged 2 commits into
ESCOMP:b4b-devfrom
johnpaulalex:fix/rm-gccanopy
Oct 15, 2026
Merged

samsrabin merged 2 commits into
ESCOMP:b4b-devfrom
johnpaulalex:fix/rm-gccanopy

Conversation

@johnpaulalex

@johnpaulalex johnpaulalex commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

This PR removes leftover Fortran comments for gccanopy_patch allocation and history fields in src/biogeophys/CanopyStateType.F90. The gccanopy_patch variable itself was deleted from the struct over a decade ago during the clm4_5_12_r192 NGEE-T ED refactoring (see massive snapshot commit 85b9d5b83).

This is a zero-impact change consisting solely of deleting ! comment blocks.

Inspired by reviving the many commented-out history fields in #4172.

Description of generative AI usage:
Google Antigravity was used to write the code and tests, followed by human-guided verification.

Specific notes

Contributors other than yourself, if any:

  • None

CTSM issues resolved or otherwise addressed, if any:

  • None

Any user interface changes (namelist or namelist defaults changes)?

  • None

Testing planned or performed, if any:

  • Viewed git diff and verified that only commented-out lines are being deleted.
  • Executed local Mac Fortran unit tests (python3 run_tests.py --test-spec-dir src) and verified that the CanopyStateType.F90.o object compiles cleanly.

Requirements before merge:

  • I have followed the CTSM contribution guidelines.
  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s): Local Mac Fortran Unit Tests
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: (a)
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe: None needed.
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?: (a)

….F90

This variable was removed from the struct over a decade ago during the clm4_5_12_r192 NGEE-T ED refactoring (see massive snapshot commit 85b9d5b). This commit removes the leftover allocation and history field comments.
@johnpaulalex
johnpaulalex changed the base branch from master to b4b-dev September 30, 2026 09:58
@wwieder wwieder added the b4b bit-for-bit label Oct 15, 2026
@wwieder

wwieder commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

This looks like a minor code clean up. @samsrabin can you add this to B4B dev?

@github-project-automation github-project-automation Bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Oct 15, 2026
@wwieder wwieder moved this from Ready to start (or start again) to In progress - b4b-dev in CTSM: Upcoming tags Oct 15, 2026
@github-project-automation github-project-automation Bot moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Oct 15, 2026
@samsrabin

Copy link
Copy Markdown
Member

@wwieder No, because it requires complete aux_clm testing before merging to b4b-dev. It'll come in next time.

@samsrabin

Copy link
Copy Markdown
Member

Oh, sorry, I just noticed those lines are comments. Merging.

@samsrabin
samsrabin merged commit 4ab1db8 into ESCOMP:b4b-dev Oct 15, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Oct 15, 2026
@samsrabin samsrabin mentioned this pull request Oct 16, 2026
9 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

3 participants