Repository navigation
Conversation
The DART_BHIST_lowres testmod set for_testing_allow_non_annual_changes in user_nl_clm. This was added to allow an ERI test to pass with this testmod. With the changes in ESCOMP/CTSM#4281, I believe this setting will no longer be needed. It would probably be safe to remove it before that CTSM version is pulled into CESM because I don't think there are currently any tests using the DART_BHIST_lowres testmod in any standard test lists - though it might break any additional testing that Kevin Raeder is doing. Removing this setting won't change behavior in any meaningful way; this setting just bypassed some error checks that should no longer need to be bypassed. I prefer removing this setting so that we're not unnecessarily bypassing error checks.
Member
Author
|
@kdraeder - fyi |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The DART_BHIST_lowres testmod set for_testing_allow_non_annual_changes in user_nl_clm. This was added to allow an ERI test to pass with this testmod.
With the changes in ESCOMP/CTSM#4281, I believe this setting will no longer be needed. It would probably be safe to remove it before that CTSM version is pulled into CESM because I don't think there are currently any tests using the DART_BHIST_lowres testmod in any standard test lists - though it might break any additional testing that Kevin Raeder is doing.
Removing this setting won't change behavior in any meaningful way; this setting just bypassed some error checks that should no longer need to be bypassed. I prefer removing this setting so that we're not unnecessarily bypassing error checks.
Specific notes
Contributors other than yourself, if any: none
Fixes: none
User interface changes?: No
Testing performed (automated tests and/or manual tests): none