Repository navigation
MCSP (multiscale coherent structure parameterization) - #1632
Closed
chihchen24 wants to merge 3 commits into
Closed
chihchen24 wants to merge 3 commits into
chihchen24 wants to merge 3 commits into
Conversation
cacraigucar
requested changes
Jul 23, 2026
| !=================================================================================================== | ||
|
|
||
| subroutine mcsp_intr_init() | ||
| use MCSP, only: MCSP_init |
Collaborator
There was a problem hiding this comment.
@chihchen24 - This has the same problem that the old PR did - The MCSP code "use"d here is not in the code in this PR. Please add it to this PR.
jimmielin
pushed a commit
to jimmielin/CAM
that referenced
this pull request
Oct 13, 2026
Verbatim copy of ESCOMP/CAM PR ESCOMP#1632 (chihchen24/CAM commits d7c57b7 "MCSP added" and 6542168 "MCSP mods added"), rebased onto cam_development at cam6_4_206. The atmos_phys submodule bump in that PR (36a6608) is not carried over; the MCSP sources are taken from the copies the PR placed under src/physics/cam. Imported unchanged as the baseline for the release cleanup that follows in this branch: decoupling from zm_conv_intr, thread safety, namelist and metadata cleanup, and moving the portable scheme to atmospheric_physics. Co-authored-by: Jack Chen <cchen@ucar.edu>
jimmielin
pushed a commit
to jimmielin/CAM
that referenced
this pull request
Oct 13, 2026
Verbatim copy of ESCOMP/CAM PR ESCOMP#1632 (chihchen24/CAM commits d7c57b7 "MCSP added" and 6542168 "MCSP mods added"), rebased onto cam_development at cam6_4_206. The atmos_phys submodule bump in that PR (36a6608) is not carried over; the MCSP sources are taken from the copies the PR placed under src/physics/cam. Imported unchanged as the baseline for the release cleanup that follows in this branch: decoupling from zm_conv_intr, thread safety, namelist and metadata cleanup, and moving the portable scheme to atmospheric_physics. Co-authored-by: Jack Chen <cchen@ucar.edu>
Collaborator
|
Superceded by #1719 - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCSP is incorporated into cam6_4_188