Repository navigation
fix(ingress): accept dash-leading challenges; redact secrets in certbot logs - #168
Merged
Merged
Conversation
…ot logs - acme-dns-alias-hook.sh: the ACME validation value is base64url and starts with "-" about once in 64; argparse then treats it as an option and the delegated auth hook fails. Pass it as --content=<value>. - certman.py: certbot output is printed on failure. lexicon's Namecheap client sends ApiKey in the query string, so a network error can put the key in the container log. Mask DNS provider credentials before printing. Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from a security pass over dstack-ingress:
-about 1 time in 64, anddnsman.pythen rejects it withargument --content: expected one argument, so the issuance or renewal fails. The hook now passes it as--content=<value>.ApiKeyin the request URL, so a network error can write the key to the container log. Values ofCLOUDFLARE_API_TOKEN,LINODE_API_TOKENandNAMECHEAP_API_KEYare now replaced with***before printing.