Repository navigation
Fix absolute host/name domain matching on label boundary (#57) - #58
Merged
Merged
Conversation
pawel-kow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57.
Problem
An absolute host/name (trailing dot) was matched against the domain as a plain string suffix, so
www.notfoo.com.on domainfoo.comwas accepted and mangled towww.noinstead of being rejected. Affected all RR types, including wildcard hosts.Fix
resolve_variablesnow strips the domain only on a label boundary ('.' + domain + '.'), in both the regular and the wildcard branch. Names outside the domain fall through to validation and raiseInvalidData.Tests
%fqdn%with/without trailing dot.host(apex, other host) are placed there; names outside the domain raiseInvalidData.Full suite passes; PR regression check: 971/971 OK.
🤖 Generated with Claude Code