Repository navigation
FIX: replace previous multi-aware instance when host is empty (#54) - #55
Merged
Merged
Conversation
Switch multi-aware process_records tests to host "" (apex). This exposes that previous instances are not replaced when host is empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54
Problem
In
process_recordswithmulti_aware=Trueandmulti_instance=False, records from a previous instance of the same template are marked_replace. The guard used a truthiness check onhost. When a template was applied at the apex withhost="", the check failed, so the previous instance was never replaced.The A-record variant didn't show the bug, because the A conflict rule deletes the old record anyway. TXT with
txtConflictMatchingMode: Nonerelies entirely on_replace, so the old record survived.Changes
process_records_tests.yamlnow usehost: ""in the input and in_dc.multi_reapply_txt_without_multi_instancefailed before the fix.DomainConnectImpl.py,host and ...becomeshost is not None and ..., so an empty host is compared against_dc.host.All 370 tests pass.
Out of scope
_dc.hoststores the rawhostvalue, so an instance applied with"@"doesn't match one applied with"". That relates to #53 and #43.🤖 Generated with Claude Code