Repository navigation
Fix PHP 8.4+ deprecations, test on PHP 8.5 - #6
Merged
Merged
Conversation
…tion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PHPUnit 9.5.26 itself raises PHP 8.4+ implicit nullable deprecations, so the suite could not run deprecation-free on PHP 8.5. The lock is resolved against PHP 7.4 so every CI job still installs from it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the package free of deprecations on PHP 8.4 and 8.5, and keeps it that way.
Fix
UnexpectedResponseException::__construct()declaredThrowable $previous = null. PHP 8.4 deprecated implicitly nullable parameters, so every client generated by api-client-generator raised anE_DEPRECATEDon PHP 8.4+:ResponseExceptionFactoryloads the exception classesThe parameter is now
?Throwable $previous = null. The meaning and signature stay the same, and the?syntax has worked since PHP 7.1 (this package requires^7.4 || ^8.0). This is the only change insrc/, so it qualifies as a patch release: 2.3.1, with a CHANGELOG entry.Test tooling
^9.5is unchanged). 9.5.26 raises the same PHP 8.4+ deprecation inside PHPUnit itself, so the suite could not run deprecation-free on 8.5. The lock was resolved against PHP 7.4, so the 7.4/8.0/8.1 jobs still install from it.convertDeprecationsToExceptions="true", so any future deprecation fails the build instead of being hidden.Verification
src/andtest/: the deprecation shows before the change and nothing shows after.🤖 Generated with Claude Code