Repository navigation
ENG-1986 Refactor Obsidian sync to use the new cross-app schemas (1/6) - #1620
Open
sid597 wants to merge 7 commits into
Conversation
Drive the full sync and the file-change sync against a fake Supabase client and compare the upsert_concepts rows exactly: node type, relation type and triple schemas, a note with its direct and full Content, and relations. Also pin the Source slot, the skipped imported notes and relations, and which Content an edit or a rename sends. The relations now come from relations.json in the fake vault. The loadRelations mock never reached the sync.
Check that every upsert_concepts call targets this space. Pin an accepted imported relation type and triple with their origin RIDs, the node type settings kept in source_data, and the full Content keeping the note's frontmatter. Give each embedding a vector that identifies its text. Name the differences upsert_concepts stores alike, so a later PR can change only those with that reason.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Compare the Source note's Concept and both its Contents exactly, so a converter that drops an empty source_data fails. Name the id-list test for what it checks: imported schemas are sent, imported notes and relations are not. State the stored-alike fact in the sentConcepts comment without the later-PR clause.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 16, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer brief
ENG-1986 moves Obsidian sync off its own converters and onto the shared CrossApp converters, without loss of functionality. It ships as six PRs. PRs 1 to 4 and 6 are stacked on #1575 (ENG-1823). PR 5 targets
main:upsert_conceptstoday. No production change.colorbecomes a CrossApp field on node types and relation types, inpackages/database. It doesn't depend on PRs 1 to 4.colorthrough the shared converters. It needs PR 5, and its branch carries PR 5's change until that merges.Why six and not one: each step changes one kind of row, and #1620's tests show whether a stored value changed. PR 5 changes the shared contract, so it goes first in its own PR and needs its own review. Together the steps are well over the 400-line guideline.
upsert_concepts, through the full sync and the file-change sync. A full sync sends 14 rows: 12 are compared whole, and the other 2 (supports-type,claim-supports-claim) only by id. Every file-change payload is compared whole. Each later PR must keep these tests passing or name every expected row it changes.author_id, and their originauthorIdlands inliteral_content.source_data. An imported triple is sent with this space's user asauthor_idand drops its originauthorId.loadRelationsmock from ENG-1823 never reached the sync. It recorded no calls while the sync ran. The tests now putrelations.jsonin the fake vault, so the realloadRelationsreads it.Verification
pnpm ci:validatepasses (Obsidian: 258 tests).metadata.filePath, omittemplate_contentfor a type with no template, name a note by its basename, name a triple by its id, stop skipping imported notes or relations, drop dependency ordering, send a differentv_space_id, strip frontmatter from the full text. A review lab's six probes also each fail a test now: a relation withoutlastModified, an imported note at a relation's source, provisional imported schemas, and rows sent before what they reference. Production files are unchanged.Loom video
No video. This PR changes only a test file.
Scope check
$scope-checkagainst ENG-1986 and the final diff.Done When: None. This PR covers the tests clause of Done When. The refactor itself is in PRs 2 to 6.Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.DiscourseGraphs/review-labat01b07f3) on2b14ca1c: one P3 finding (F-B6), listed under Risk; nothing blocks review. Review Lab page