Repository navigation
Roam settings menu overhaul (M2) - #1525
Open
trangdoan982 wants to merge 17 commits into
Open
trangdoan982 wants to merge 17 commits into
trangdoan982 wants to merge 17 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This was referenced Oct 16, 2026
2 of 3 tasks
…with four topic-based sections (#1373) * ENG-2189 Reorganize Roam settings into four topic-based sections Settings were grouped by who they affect (Personal/Global), so Home and Left sidebar each appeared twice and one feature's settings spanned both sections plus a separate Canvas tab. Regroup every setting under Preferences / Features / Grammar / Advanced. Relocation only: no stored value, default, behaviour or copy changes. Titles that double as legacy block keys (trigger, Canvas Page Format, Export rows) keep their exact strings. - Split GeneralSettings and HomePersonalSettings into PreferencesGeneral, PreferencesStyling, DiscourseContextSettings, CanvasSettings and LeftSidebarSettings. - Merge the two Left sidebar tabs into one and move it under Features, with its enable toggle on the tab so the tab stays reachable when off. - Rename tab ids to the taxonomy scheme and alias the nine legacy ids so saved deep links keep resolving. - Extract useLegacyConfigUids so the panels that mirror into the legacy block tree keep their uid/parentUid/order after moving files. - Group the graph-wide node trigger with its personal override. - Anchor setting rows by key for ENG-2184. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2189 Make the legacy block key the explicit override, not the label `title` was doing two jobs on the panels that mirror into the old config tree: the text shown to the user and the exact block text discourseConfigRef reads by. The `label` prop patched the display side so `title` could stay pinned; `blockKey` instead names the storage side, so `title` is display text everywhere and only the three legacy-mirrored panels say which block they write to. useLegacyConfigBlocks now returns the block text, order, uid and parentUid together per setting, so a call site spreads one object instead of pairing a uid with an order by hand, and the reader's spelling lives in one table. It also stops refreshing the config tree during render: every writer in the dialog refreshes after writing and the dialog refreshes on close, so the call was repeating that work on each tab visit — including the default tab, which never paid it before. Behaviour change, deliberate: the left sidebar flag panel now creates its block as "(BETA) Left Sidebar", the text the reader looks up, rather than "Left Sidebar", which it never found. Only graphs without the block yet are affected. Also folds the one className every SectionHeader passed into the component, which removes a font-bold/font-semibold conflict, and drops the ADMIN_TAB_ID alias. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2189 Group headings carry the hierarchy; Node trigger moves last Review feedback on the Preferences > General page: - Grouped rows were indented, which made the Node trigger pair the one indented thing on the page and left the separators inconsistent at the group boundary. Groups now sit flush and the heading does the work: one small-caps heading style shared by SettingsGroup and SettingsSectionHeading. - The Node trigger group moves to the bottom of the page. - The personal override input showed a placeholder that did not fit its keycap width. It shows nothing until focused; the graph-wide default is one row up. - The left sidebar sub-headings keep the words the tabs used to carry, Global and Personal, rather than new copy. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2189 Size the section heading above its rows and rule under it Review choice C: the 12px small-caps heading was the smallest text on the page, under 14px semibold row labels. Headings are now 16px semibold over a 2px rule — heavier than the 1px row hairlines, so a section break reads by weight as well as size — and live in settingsStyles.css because Roam has no Tailwind preflight to paint a border. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2189 Trim comments to the decisions they record Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2189 Address bot review findings on settings reorganization Blueprint palette with a .bp3-dark override replaces two custom properties that were defined nowhere; Tailwind takes over the group wrapper. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2189 Style the settings heading with Tailwind, CSS for colors only Roam's tailwind.min.css has no preflight, so `border-b-2` needs an explicit `border-0 border-solid` to paint. Colors stay in CSS for the .bp3-dark override. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2189 Lay the canvas shortcut rows out with flex The grid's only explicit track sizing was `grid-cols-[auto_auto]`, which Roam's Tailwind build never generated; the columns came from `col-span-2` instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2189 Drop the canvas overlay setting removed by ENG-2096 ENG-2096 deleted the feature and its setting key on main. This branch would have re-homed the panel into a new file, where the merge cannot delete it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2189 Give the migrated settings components explicit return types Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2189 Style the section heading with Blueprint and Tailwind classes `bp3-heading` already carries the themed text color (#182026 light, #f5f8fa dark), so settingsStyles.css no longer needs a colour rule or a dark override. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2189 Hide the Left sidebar tab while the feature is off The enable toggle moves to Preferences > General, so the tab no longer has to host the control that un-hides it. Blueprint still renders a hidden tab's panel, so the selection is redirected to General as well. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…#1375) * ENG-2186 Grammar › Nodes drill-down and settings navigation primitive Replaces the per-node-type rail tabs with a single Grammar › Nodes entry that drills from the node list into a node type's page, with a back button and a breadcrumb. The route state is a path reducer (select-tab / push / pop / truncate) exposed through SettingsNavContext; an incoming id that is not a known tab is treated as a node type uid so the old per-node deep links keep resolving. Also carries the write plumbing the drill-down made necessary. Panels debounce their writes and used to cancel the pending one on unmount; a back button puts an unmount one keystroke from every input, so a commit now runs exactly once by timer, flush, or unmount (useDeferredWrite). Legacy block writes go through an awaitable hook registered with the same in-flight tracker, and every commit re-reads the config tree only after its write resolves, so a reader that flushes first (the export) sees the value it was just given. The node type page itself keeps its inner tabs here; ENG-2188 rebuilds it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2186 Deferred commits always return a promise; format the stylesheet Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2186 Drop the colour dot from the drill-down header Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2186 Style the settings route and page header with Tailwind Roam ships Tailwind, so the hand-rolled dg-settings-* rules were redundant with the utilities the rest of apps/roam already uses. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2186 Use the ~ alias for the settings navigation imports Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2186 Remove the pending-write registry and Roam write tracking The registry, flushPendingSettingWrites and trackRoamWrite have no consumer at this point in the stack; their only caller is Export, two PRs above. Tracked in ENG-2286, which must land before ENG-2185. useDeferredWrite still commits on unmount rather than cancelling: Back and the breadcrumbs added here are fast unmount paths mid-debounce. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2186 Remove the settings-write changes from this PR Reverts the deferred-write rework, the template buffer flush and its delete ordering, and the node colour commit-on-unmount. Only the optional title on the template panel stays, which the drill-down needs. This PR is now presentation only. The debounce bug is ENG-2287 and the flush-before-read is ENG-2286. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2186 Remove a stray file committed by accident Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…hem on one page (#1420) * ENG-2188 Node type settings are spread across seven inner tabs; put them on one page A node type's settings become one vertical page: Identity (Index first, then Description, Tag, Color, Format), Creation, Canvas, Legacy (Specification), the sync-gated Suggestive mode, and Attributes last. Index and Template are drill-down rows on the ENG-2186 primitive, each with its own sub-page. Specification's toggle reads "Enabled" (its lowercase block text stays the storage key via blockKey) and the query builder renders only while it is on. Format loses its DEPRECATED note: Specification is the one in migration. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2188 Style the node config page container with Tailwind Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * reduce gap --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…1374) * ENG-2185 Move export settings out of Settings into the Export panel The 7 export controls were used by exactly one surface but lived in Settings, so changing an option meant leaving the Export flow, opening Settings, and coming back. Move them into a collapsed "Export options" disclosure at the bottom of the Export dialog's Export tab, and remove the Advanced > Export tab that ENG-2186 parked in Settings for this change to take out. The controls, their storage keys, and the read path in getExportSettings are unchanged, so saved values persist and export behaviour is untouched. The advancedExport tab id goes with it, and the saved "discourse-graph-export" deep link now resolves to the default tab instead of a tab that no longer renders. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * Drop the stale Settings screenshot from the sharing guide The image showed the export options inside the Settings dialog, with the vertical tab list and the pre-taxonomy tab names. Both the Export tab and that chrome are gone, so the screenshot contradicted the prose above it. Removed rather than replaced: the surrounding text already names where the options live, and no fresh capture of the Export dialog is available yet. The frontmatter close-up further down is a crop of the control itself, so it stays accurate and is kept. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2185 Commit and settle deferred option writes before the export reads The number and select panels in Export options defer their block-prop write behind a short timer, so an option edited a moment before clicking Export was read at its previous value. Awaited rather than fired: the commit only starts the Roam block update, so a synchronous flush would not have been enough on its own. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2185 Put Export options beside the result count and re-read on open Review feedback on the Export dialog: the options toggle sits on the left of one row with "Exporting N results" and the discourse-context checkbox on the right, instead of taking a row of its own. The option panels are also seeded from a fresh settings read each time the section opens. Collapse unmounts them while closed, so reading once at dialog mount meant a long-lived dialog could show values that had since changed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2185 Discourse context on its own line above the export options row Review feedback: the checkbox sits right-aligned on the line above; the line below is the Export options toggle on the left and the result count on the right. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2185 Drop unit tests and trim comments to the decisions they record Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2185 Put Discourse context inside Export options with an info tooltip Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2185 Remove the pending-write flush from the export path The flush and its registry move to ENG-2286, which blocks this ticket. Known gap until then: the export settings and the Export button share this dialog, so an option edited within ~350ms of pressing Export is read at its previous value. No unmount happens in that path, so the commit-on-unmount in ENG-2186 does not cover it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
* ENG-2183 Build the new setting-item row component
Add one shared settings row — scope indicator, label, always-visible
description, control — and route every panel-based row through it.
Descriptions move out of the hover popover that dismissed before its doc links
could be clicked (ENG-2080). The fix is structural: the description renders as a
sibling of the label, never a descendant, so a link inside it can no longer
toggle the row's control.
The rewire happens at SettingTitle, the one helper all five Base*Panels funnelled
label and description through, so ~70 call sites are unchanged. Flag rows swap
Checkbox for Switch to match the design.
Scope is derived from the wrapper rather than passed per call site, because the
wrapper already binds the setter that decides who a value is written for. Rows
that cannot derive it pass `scope` explicitly.
Layout is Tailwind, which resolves because Roam itself bundles Tailwind. Anything
depending on Tailwind's preflight is hand-rolled instead: `border-b` and `border`
set only a width, and `* { border-style: solid }` is absent, so those borders
never paint. This repo's own `neutral-*` theme colours are likewise absent from
Roam's build and are mirrored as CSS variables.
Supersedes ENG-2186's SettingsDrillDownRow, whose two callers now compose the
shared row with a trailing drill-down summary.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* ENG-2183 Badge per-node settings as global, not their own scope
A node type's settings are written to that node type's own page block props, so
the whole graph sees them — the agreed badge model has two values, `just you`
and `everyone`, and a per-node scope was never one of them. Drops the invented
`nodeType` scope and its icon; the nine affected rows now badge as `global`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* ENG-2183 Consistent separators, a compact row, and the number input overflow
Review feedback on the row component:
- Separators ran between sibling rows only, so they stopped at every group
boundary. Each row now owns its bottom edge.
- BaseNumberPanel put `w-24` on the NumericInput, but Blueprint applies that
class to the outer ControlGroup while the input keeps its intrinsic width;
the box shrank and the input spilled past it (Advanced > Queries, and the
same control in Export options). The width now sits on a wrapper and the
input fills it.
- The Export dialog is too narrow for the trailing layout, so rows take a
`compact` presentation there: no scope badge, control below the label,
tighter vertical spacing — the shape the options had before this component.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* ENG-2183 No hairline after a group's last row
The group heading's 2px rule already frames the group; a 1px hairline after
its last row put two rules at one boundary.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* ENG-2183 Drop row dividers; only section headings draw a rule
Hairlines under rows were inconsistent — present on flat rows, dropped after a
group's last row, absent on rows not yet on SettingItemRow — so they told the
eye nothing reliable. A line now appears in exactly one place, under a section
heading.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* ENG-2183 Drop unit tests and trim comments to the decisions they record
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* ENG-2183 Remove duplicated Specification and Index rows from the Identity group
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* ENG-2183 Inherit host colors and label simple controls in setting rows
Drop the new --dg-* neutral palette: the row label and scope icon now
inherit Roam's foreground, so dark and custom themes stay readable. The
scope badge uses a translucent neutral that works on either background.
Pass the node search trigger, personal node menu trigger, and node color
controls as render callbacks so their generated id reaches the input and
the row's <label> associates with it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…1379) * ENG-2213 Settings catalog: address every setting by key and location Records what every setting row is called and where it lives, so a later change can find a setting without knowing which tab it is on. Nothing in the codebase held this. `zodSchema.ts` is storage shape — no labels, no descriptions, no locations — and `settingKeys.ts` holds block keys that diverge from what a row renders: `GLOBAL_KEYS.trigger` renders as "Graph-wide default", `PERSONAL_KEYS.personalNodeMenuTrigger` as "Personal override". Nor can it be collected at runtime: `Tabs` uses `renderActiveTabPanelOnly`, so inactive panels are out of the DOM and rows cannot self-register. So the label, group, description, doc link and location are authored, one entry per row. Everything else is derived rather than restated. Entries are keyed by `GROUP.member`, addresses are built by resolving that id against the `settingKeys.ts` constants, and the catalog is declared `satisfies Record<RowKeyId, AuthoredSetting>`. A key added to `settingKeys.ts` is then a compile error until it is either given an entry or listed in `NonRowKeyId` with a reason, so a new setting cannot silently go missing. The remaining gap is the reverse direction: nothing checks that a row rendering `settingKeys` was classified as a row rather than exempted. An entry's `path` is the only field a relocation has to touch. Node-type settings give `path` as a function of the node uid, so one entry expands to one result per node type and adding a node type never edits this file. Six rows rendered without an anchor, so they had no stable address; each now passes the key constants already in scope at its call site. `SETTINGS_TAB_META` becomes the single source for tab labels, because a renamed tab would otherwise drift away from the locations recorded here. `SettingItemRow` falls back to the catalog for a description when the prop is omitted, so ENG-2187 can migrate call sites by deleting props rather than by copying text. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2213 Make the canvas shortcut overrides searchable The key was exempted as "persisted UI state and canvas-written values", but CanvasShortcutSettings renders it as a visible editor under Features > Canvas, so a real setting was missing from the index: searching "canvas shortcut" only found the discourse tool shortcut. Authored as one row rather than one per node type, because the overrides share a single stored value; the anchor goes on the grid so a jump lands on it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2213 Cover the catalog's addressing and coverage rules The catalog is what makes search navigable, and its invariants fail quietly: a duplicate id breaks React keys, a nested setting that drops its parent segment collides with a same-named top-level key, and an entry pointing at a tab that no longer exists sends the user nowhere. Also pins the two rules the export move introduced: settings living outside the Settings dialog stay out of the index, and stay authored here anyway so their rows keep reading one description. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2213 Drop the SettingsTabId alias now defined alongside isSettingsTabId Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2213 Follow the node page regroup in the catalog Index and Format now sit under Identity and Specification under Legacy, so the breadcrumbs search shows match the page. Format's description loses the DEPRECATED note along with the row. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2213 Drop unit tests and trim comments to the decisions they record Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2213 Anchor the Index and Specification rows by setting key Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2213 Drop the catalog row for the removed canvas overlay setting ENG-2096 removed the setting on main. The catalog is exhaustive over the key groups, so its row had to go with the key. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2213 Record the left sidebar toggle under Preferences > General ENG-2189 moved the row so the tab can hide itself. `path` is data, so nothing would have failed: search would just have navigated to the wrong tab. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2213 Say what the legacy section keywords are for Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
* ENG-2184 Add search to the settings panel Adds the search field at the top of the settings rail: type a setting's name, section or description and jump to it wherever it currently lives. Matching is a plain substring pass over the entries ENG-2213 records, ranked so that an exact label always beats a section or description that merely mentions the word. Tabs are offered as their own result kind, so "export" reaches the Export page even though no setting is named that. The catalog is rebuilt per query rather than cached for the dialog's lifetime, because node types and feature gates can both change while Settings is open. The results are a portalled Popover, not an in-flow dropdown: the field lives inside Blueprint's tab list, which Settings styles `overflow-y: auto; overflow-x: hidden`, so an in-flow panel is clipped on both axes. It also paints its own surface, because Roam ships its own Blueprint build and themes `.bp3-popover` — inheriting the library default leaves the panel transparent with the rail showing through it. Jumping needs a new `navigate` action: the reducer could only push one segment at a time, and a setting can be several segments deep. The row is not in the DOM when the jump is dispatched, since only the active tab's panel renders, so the scroll retries by frame until the row appears or a budget runs out — at which point the user is at least on the right page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2184 Let the search-result flash outlive the jump that started it Finding the row settled the jump, which cleared anchorId and so re-ran the effect; its cleanup then stripped the flash class on the very next render. The row scrolled into view with no indication of which one had matched. The flash now owns its own lifetime instead of the effect's, and re-flashing a row already flashing restarts the animation rather than riding out the first. Only the frame-by-frame lookup stays cancellable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2184 Cover the search ranking tiers The tier order is the behaviour worth pinning: an exact label must not be buried under a description that happens to mention the same word, and a multi-word query must match across fields without diluting single-word precision. Both are easy to regress while tuning and neither is visible without a query that exercises the boundary. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ENG-2184 Inset the search field to the rail's text edge Review feedback: the box sat flush with the rail while every tab title under it was indented. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2184 Escape backslashes in the anchor selector; drop a redundant cast The selector only escaped double quotes; a backslash in an anchor id could still break out of the attribute string. Keys are authored today, so this is belt-and-braces rather than a live bug. The test helper's `as SearchableEntry` was already the expression's type, which the changed-files lint flags as a warning and fails on. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2184 Drop unit tests and trim comments to the decisions they record Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * ENG-2184 Style settings search with Roam's Tailwind and host surfaces Results sit inside Blueprint's Menu so the theme paints them, the jump highlight is padded and fades via Tailwind, and imports use the ~ alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ENG-2184 Name the node type in repeated results and add node type pages Per-node rows read "Issue › Index" and no longer match on their shared breadcrumb or description, and each node type gets its own page result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ENG-2184 Rank one-off results above per-node rows, unclip the search flash, and match relation names Label matches come first, and among them pages and one-off settings precede rows repeated per node type. Scroll boxes leave room for the flash's -mx-2. The Relations page matches each relation's label and complement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M4BYAMM5JVAZT6D3ZN4WX3BA
ENG-2183 routed every settings panel through SettingItemRow, so the export options picked up the new row and a Switch. They now render like "Discourse context": a checkbox with its description, and label-over-control fields. `compact` is replaced by `inline`, whose only caller is ExportOptions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M4BZHS74Y5EYMH6SPR55EHDQ
…1556) * ENG-2407 Point settings docs links at the docs that describe each setting Link to section anchors where a page covers several settings, drop links whose docs don't describe the setting, and rename "See more." to "View docs". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M5330M4CR1A4PNK15KZZNZT2 * ENG-2407 Pass unwrapped setting descriptions as plain JSX strings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M53396FYSXNFSKP0CH8ZB3Q1 * ENG-2407 Drop the Auto canvas relations docs link No docs page describes adding relations automatically. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M53BSZCK7MY7GHT5QBJ92TQQ --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tip cursor, search highlight (#1558) * ENG-2410 Settings layout polish: max width, cut-off placeholder, tooltip cursor, search highlight Cap row-based settings tabs and the node config page at 720px, shorten the personal override placeholder, give the scope icon the default cursor, and hold the search highlight longer and darker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M554BHSAE38GC59P1EMYHPDT * Drop a comment that restates the row panel constant Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M554JBZZDFSA925YKC6ER68J * Keep the specification query editor out of the node page width cap Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M555JFG5EAQMHRA22JEYA7XN * Shorten the discourse tool shortcut placeholder so it fits Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M5DSV3RANEN2ZF9HZA81HWBS --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ns and sticky headers (#1559) * ENG-2409 Add collapsible sections and sticky headers to settings pages Node type sections collapse individually or all at once, with state kept for the dialog's lifetime. Section headings stick on every settings page, and a settings search jump expands all sections before scrolling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M552YDYWGGAM3E59DKHH4QD9 * Address review: theme-matched sticky background, scoped realign scroll Copy the sticky heading background from the dialog so Roam themes that restyle .bp3-dialog without .bp3-dark stay opaque and matching. Realign a collapsed stuck section on its own scroller only, and build the collapse all button only on the node page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M55386K5C0G4VQRKR9MD21AX * Only reset node section collapse for search jumps into Grammar > Nodes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M553DVNG21Y06NX5YBQZ7722 * Use functional collapse updates and ignore held keys on section headings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M553MEG7DZPAB3N071WTHMCP * Animate section collapse with Blueprint Collapse Search jumps wait until an expanding Collapse reaches height: auto before scrolling, so the row is not missed mid-animation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M553ZJ3WFZGKSK5BYG4FZBBW * Keep collapsed rows out of tab order and time-box the expand wait Mark collapsed section content inert, wrap only collapsible groups in Collapse, wait on a 500ms clock rather than a frame count, and reset collapse state only for setting jumps into Grammar > Nodes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M554EQDMB7D3FMH32V5TYS2N * Fix lint warnings in section tests and type the reveal helper Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M555TP1V9DCMNS8DDSFSKXHJ * Type the positional-children test wrapper so check-types passes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M555X702GD83ZXW9YBJGBCHJ --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tings copy (#1554) Entire-Checkpoint: 01M533T2XCT0PDA3TSQ13CNCXQ Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
trangdoan982
force-pushed
the
roam-setting-overhaul
branch
from
November 12, 2026 01:21
8415519 to
9a30dac
Compare
The 720px cap paired a plain selector with a :has() one in a single comma-separated rule, so a browser without :has() would have dropped the cap from every settings page, not just node config. .dg-settings-node-page had no users left. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Entire-Checkpoint: 01M78HB85CS7GFY2P0SJ163HMC
trangdoan982
marked this pull request as ready for review
November 12, 2026 19:21
Contributor
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Settings search can jump straight from one node's page to another's. The node forms seed their state from props once, so the previous node's tag, format and shortcut stayed in the inputs and editing any of them wrote those values to the new node. Keying the three node-scoped routes by node.type remounts them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Entire-Checkpoint: 01M78MV78SJ2SEZEEGTEW24RNX
It explains all three keys, so it does not belong inside the first branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Entire-Checkpoint: 01M78N382KSFR3B7HBY1R89RCS
It rendered after the group's heading, so it read as a third trigger setting. The catalog already treats it as ungrouped; the group is now last on the page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 01M7JS829XWXFGZ0TW3ET9SSKT
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/74
Reviewer brief
roam-setting-overhauland rebased ontomain.a873847dRemount node pages when the node changes — fixes a data-loss bug found in review, see below.94fde66dKeep the Export dialog's options in their pre-overhaul style — repairs the Export dialog after ENG-2183 routed every settings panel throughSettingItemRow.5fa39c75Split the settings max-width rule and drop a dead class.33965d12Move the node-key comment above the branch chain.03cb25bcDrop an unusedsettingAnchorimport.a873847d: settings search can jump straight from one node's page to another's. The node forms seed state from props once, so Evidence's tag, format and shortcut stayed in the inputs under Result's placeholders, and editing any field would have written Evidence's values onto Result. Keying the three node-scoped routes bynode.typeremounts them. This also fixed a second instance of the same class,DiscourseNodeIndexcarryingshowQueryacross node types.buildPagesgates onsearchablewith noisAvailable); FEE-921 records the matching relation-search gap.ExportOptionsrestores the pre-overhaul markup but not the old control sizing. The Format row's description lost itsDEPRECATED - Use specification instead.prefix in the ENG-2408 copy pass — confirm that was intended.Verification
Rebased onto
mainwith no conflicts; the diff againstmainwas byte-identical to the pre-rebase branch, so the replay changed no content.turbo check-types --forceandturbo run test:unit --forceboth pass with nothing cached (8/8 and 6/6); inapps/roam,tsc --noEmitpasses, ESLint reports 0 errors, Vitest passes 77 files and 723 tests, Prettier is clean.Exercised in real Roam throughout, against builds stamped with this branch and head. All four topic sections render and the Personal/Global split is gone; all eight leaf pages load;
Grammar › Nodes › <node>drills down to one page with collapsible Identity/Creation groups; settings search returns breadcrumbed results; the Export dialog's options render as checkboxes, not switches. Thea873847dbug was reproduced and then confirmed fixed by the same navigation path — Result's page now shows#res-candidate/R/[[RES]]…instead of Evidence's values. After the CSS split, both halves of the 720px cap still apply: row panels720px, node-config children720pxexcept the specification child,none.No automated regression test for the remount:
apps/roamhas no component-test harness (vitest runs innode, no jsdom or testing-library), so adding one would mean new dependencies and belongs in its own PR.Loom video
https://www.loom.com/share/55c59c27ea314ec1a577295a980ed10d
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: integration branch; every ticket commit was scope-checked against its own ticket in the linked PRs. The four non-ticket commits all repair regressions introduced inside this branch rather than adding scope: the Export dialog restyle after ENG-2183's shared-component rewire, the node remount and its comment, and the CSS split repairing ENG-2410's own width cap.Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.🤖 Generated with Claude Code