Skip to content

Fast_dp and AutoPROC wrappers swap beam centre values #400

Closed

Description

@pblowey

Sub-issue of https://github.com/DiamondLightSource/mx-analysis/issues/81
All of the autoprocessing pipelines swap the x and y assignment of the refined beam centre when uploading to the database.

For AutoPROC and fast_dp, the swap occurs within the wrappers. For fast_dp, the output is written in the convention of (y,x) ordering, with y typically being the slow direction, however the wrapper interprets it in (x,y) order. For AutoPROC, the pipeline reports the data correctly but the wrapper has been swapping the values, presumably to keep them consistent with the other (incorrect) pipelines.

This PR corrects the assignment and reports the right values as x and y to the database.

For xia2, the swap occurs internally, with the explicitly labelled xia2 output reported the wrong way round, so this issue is being fixed in xia2 itself.

Activity

  1. self-assigned this
    on Oct 21, 2026
  2. linked a pull request that will close this issueUnswap beam centre values #401on Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions