Repository navigation
The browser design says how a second launch would bring a zone's open Firefox forward - #515
Merged
Merged
Conversation
…a zone's open Firefox forward instead of starting another
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Firefox in a zone has no remote: the image leaves out both D-Bus and X11. So pressing the browser key (Alt+Shift+u), or the menu's
b, a second time for a zone whose browser is open starts a secondfirefox. That instance finds the profile locked and says Firefox is already running. Nothing in the design said what should happen instead.What changed
A section in
docs/design/browser-and-graphics.md, "A second launch where Firefox is open". It is design only, nothing built:app_id, tags and focus order. A match on theapp_idis sought only among one zone's windows.app_ids, recorded by the chrome, and a one-line request file. dwl watches that file the way it watches the microphone and camera marks, in the session's 0700 runtime directory. The chrome keeps the launch, since the passphrase is asked on its terminal.How checked
Read against the current code. dwl's status already names the focused window's zone by socket (
dwl-zone-borders.py, thezonestatus line). The key isuntrustedcmdinbuild/desktop/dwl-config.h. The menu'sblaunches throughkryptik-launch --askintools/desktop/kryptik-chrome. The section is wrapped at the document's width.