Repository navigation
run-ovmf refuses --second-head with --s3, whose guest has no second output - #513
Merged
Merged
Conversation
…td VGA and has no second output
DevomB
marked this pull request as ready for review
October 15, 2026 07:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
tools/image/run-ovmf.sh --gpu --s3now shows the guest through std VGA's framebuffer instead of virtio-vga. 6.18's virtio-gpu has no suspend callbacks, so a guest that sleeps on it never gets its display back (#451). The second monitor of--second-headis a second output of virtio-vga, and is added only in the virtio-vga branch. So--second-head --s3together would start a guest with one monitor, saying nothing about it.No caller combines them today. 67 noted it in the read of #451's change.
What changed
The pair is refused at the start, beside
--second-head's existing rule: "--second-head needs virtio-gpu, which --s3 gives up for std VGA's framebuffer".How checked
bash -n. The rule uses the same[[ … ]] && dieform as the line above it, which is safe under the script'sset -e. Nothing intools/imagepasses both flags, so no suite's run changes.