Skip to content

run-ovmf refuses --second-head with --s3, whose guest has no second output - #513

Merged
DevomB merged 1 commit into
mainfrom
s3-no-second-head
Oct 15, 2026
Merged

DevomB merged 1 commit into
mainfrom
s3-no-second-head

Conversation

@DevomB

@DevomB DevomB commented Oct 15, 2026

Copy link
Copy Markdown
Owner

What was wrong

tools/image/run-ovmf.sh --gpu --s3 now shows the guest through std VGA's framebuffer instead of virtio-vga. 6.18's virtio-gpu has no suspend callbacks, so a guest that sleeps on it never gets its display back (#451). The second monitor of --second-head is a second output of virtio-vga, and is added only in the virtio-vga branch. So --second-head --s3 together would start a guest with one monitor, saying nothing about it.

No caller combines them today. 67 noted it in the read of #451's change.

What changed

The pair is refused at the start, beside --second-head's existing rule: "--second-head needs virtio-gpu, which --s3 gives up for std VGA's framebuffer".

How checked

bash -n. The rule uses the same [[ … ]] && die form as the line above it, which is safe under the script's set -e. Nothing in tools/image passes both flags, so no suite's run changes.

@DevomB
DevomB marked this pull request as ready for review October 15, 2026 07:44
@DevomB
DevomB merged commit cce9125 into main Oct 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant