Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several new type contracts reject supported scalar rows or valid filter/export calls.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Adds TypeScript types and ESLint-compliant constructs to GridCore helper modules while preserving aggregation, accessibility, filtering, and export behavior.
Changes:
- Types aggregation inputs, helpers, and summary integration.
- Types group filtering and keyboard accessibility helpers.
- Refactors export preparation with generic item types.
| File | Description |
|---|---|
grid_core/m_export.ts |
Adds generic export-item types and lint fixes. |
grid_core/m_accessibility.ts |
Types keyboard action registration. |
data_grid/summary/types.ts |
Allows optional aggregation group indexes. |
data_grid/summary/m_summary.ts |
Types aggregate calculation data. |
data_grid/m_utils.ts |
Types group-filter construction. |
data_grid/m_aggregate_calculator.ts |
Types and modernizes aggregation helpers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| constructor(options: { | ||
| data: any; | ||
| data: RawItemData[] | GroupData<RawItemData>[]; |
| export function createGroupFilter( | ||
| path: unknown[], | ||
| storeLoadOptions: Pick<StoreLoadOptions, 'group' | 'filter'>, | ||
| ): DataFilter { |
|
|
||
| private calculateTotalAggregates( | ||
| data, | ||
| data: RawItemData[] | GroupData<RawItemData>[], |
|
|
||
| function prepareItems<T extends ExportItem>( | ||
| items: T[][], | ||
| emptyCell: Partial<T>, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.